JDK-8289146: containers/docker/TestMemoryWithCgroupV1.java fails on linux ppc64le machine with missing Memory and Swap Limit output

[MBaesken]

On Linux ppc64le machines , the test fails with

stderr: [WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap.
]
exitValue = 0

java.lang.RuntimeException: 'Memory and Swap Limit is: 157286400' missing from stdout/stderr

at jdk.test.lib.process.OutputAnalyzer.shouldContain(OutputAnalyzer.java:221)
at TestMemoryWithCgroupV1.testMemoryLimitWithSwappiness(TestMemoryWithCgroupV1.java:84)
at TestMemoryWithCgroupV1.main(TestMemoryWithCgroupV1.java:61)
at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
at java.base/java.lang.reflect.Method.invoke(Method.java:578)
at com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:312)
at java.base/java.lang.Thread.run(Thread.java:1596)

This is most likely related to "kernel does not support swap limit capabilities",
we've seen similar issues on other Linux ppc64 le machines in some tests before.
So there needs to be some special handling added to the test for the case without kernel swap limit capabilities.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8289146: containers/docker/TestMemoryWithCgroupV1.java fails on linux ppc64le machine with missing Memory and Swap Limit output

Reviewers

• Severin Gehwolf (@jerboaa - Reviewer) ⚠️ Review applies to f81053b2
• Martin Doerr (@TheRealMDoerr - Reviewer) ⚠️ Review applies to f81053b2
• Ioi Lam (@iklam - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9319/head:pull/9319
$ git checkout pull/9319

Update a local copy of the PR:
$ git checkout pull/9319
$ git pull https://git.openjdk.org/jdk pull/9319/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9319

View PR using the GUI difftool:
$ git pr show -t 9319

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9319.diff

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@MBaesken The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (5aec24ae)
• 01: Full - Incremental (75908bf6)
• 00: Full (f81053b2)

[jerboaa]

Looks fine. It matches what we do elsewhere in container tests.

[openjdk]

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289146: containers/docker/TestMemoryWithCgroupV1.java fails on linux ppc64le machine with missing Memory and Swap Limit output

Reviewed-by: sgehwolf, mdoerr, iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 59 new commits pushed to the master branch:

• 77c3bbf: 8289617: Remove test/jdk/java/net/ServerSocket/ThreadStop.java
• a5934cd: 8289698: AArch64: Need to relativize extended_sp in frame
• fd1bb07: 8287603: Avoid redundant HashMap.containsKey calls in NimbusDefaults.getDerivedColor
• 4c997ba: 8289520: G1: Remove duplicate checks in G1BarrierSetC1::post_barrier
• 1b997db: 8289427: compiler/compilercontrol/jcmd/ClearDirectivesFileStackTest.java failed with null setting
• 688712f: 8289633: Forbid raw C-heap allocation functions in hotspot and fix findings
• df063f7: 8289484: Cleanup unnecessary null comparison before instanceof check in java.rmi
• 9ccae70: 8287593: ShortResponseBody could be made more resilient to rogue connections
• bad9ffe: 8288947: G1: Consolidate per-region is-humongous query in G1CollectedHeap
• b5d9656: 8288971: AArch64: Clean up stack and register handling in interpreter
• ... and 49 more: https://git.openjdk.org/jdk/compare/b96ba19807845739b36274efb168dd048db819a3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[TheRealMDoerr]

LGTM, too. Shouldn't this test get fixed in 19?

[MBaesken]

Please check the new version; it still throws the exception in case the full check fails; but outputs a warning about potentially wrong / missing cgroup_enable=memory swapaccount settings of the machine .

[MBaesken]

I adjusted the warning output, hopefully it is clearer now.

[iklam]

LGTM

[MBaesken]

/integrate

[openjdk]

Going to push as commit d8f4e97.
Since your change was applied there have been 64 commits pushed to the master branch:

• f783244: 8289706: (cs) Avoid redundant TreeMap.containsKey call in AbstractCharsetProvider
• fafe8b3: 8289604: compiler/vectorapi/VectorLogicalOpIdentityTest.java failed on x86 AVX1 system
• 3515604: 8280481: Duplicated stubs to interpreter for static calls
• d48694d: 8283335: Add exists and readAttributesIfExists methods to FileSystemProvider
• c45d613: 8289687: [JVMCI] bug in HotSpotResolvedJavaMethodImpl.equals
• 77c3bbf: 8289617: Remove test/jdk/java/net/ServerSocket/ThreadStop.java
• a5934cd: 8289698: AArch64: Need to relativize extended_sp in frame
• fd1bb07: 8287603: Avoid redundant HashMap.containsKey calls in NimbusDefaults.getDerivedColor
• 4c997ba: 8289520: G1: Remove duplicate checks in G1BarrierSetC1::post_barrier
• 1b997db: 8289427: compiler/compilercontrol/jcmd/ClearDirectivesFileStackTest.java failed with null setting
• ... and 54 more: https://git.openjdk.org/jdk/compare/b96ba19807845739b36274efb168dd048db819a3...master

Your commit was automatically rebased without conflicts.

[openjdk]

@MBaesken Pushed as commit d8f4e97.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.