Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8289434: x86_64: Improve comment on gen_continuation_enter() #9320

Conversation

reinrich
Copy link
Member

@reinrich reinrich commented Jun 29, 2022

Change code comments for gen_continuation_enter() explaining that the generated code will call Continuation.enter(Continuation c, boolean isContinue) if the continuation give as first parameter is run for the first time.

Also mention the special case for resolving this call.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8289434: x86_64: Improve comment on gen_continuation_enter()

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9320/head:pull/9320
$ git checkout pull/9320

Update a local copy of the PR:
$ git checkout pull/9320
$ git pull https://git.openjdk.org/jdk pull/9320/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9320

View PR using the GUI difftool:
$ git pr show -t 9320

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9320.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 29, 2022

👋 Welcome back rrich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 29, 2022
@openjdk
Copy link

openjdk bot commented Jun 29, 2022

@reinrich The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jun 29, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 29, 2022

Webrevs

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial. Thank you for fixing comments in this new code.

@openjdk
Copy link

openjdk bot commented Jun 29, 2022

@reinrich This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289434: x86_64: Improve comment on gen_continuation_enter()

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 15efb2b: 8289238: Refactoring changes to PassFailJFrame Test Framework
  • b6bd190: 8288985: P11TlsKeyMaterialGenerator should work with ChaCha20-Poly1305
  • ba670ec: 8289094: [JVMCI] reduce JNI overhead and other VM rounds trips in JVMCI
  • 0709a6a: 8284942: Proxy building can just iterate superinterfaces once
  • 2961b7e: 8285364: Remove REF_ enum for java.lang.ref.Reference
  • 167ce4d: 8289421: No-PCH build for Minimal VM was broken by JDK-8287001
  • 108cd69: 8283726: x86_64 intrinsics for compareUnsigned method in Integer and Long

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 29, 2022
@reinrich
Copy link
Member Author

reinrich commented Jul 1, 2022

Thanks for reviewing!

/integrate

@openjdk
Copy link

openjdk bot commented Jul 1, 2022

Going to push as commit d260a4e.
Since your change was applied there have been 23 commits pushed to the master branch:

  • 124c63c: 8288294: [vector] Add Identity/Ideal transformations for vector logic operations
  • 918068a: Merge
  • c20b3aa: 8289278: Suspend/ResumeAllVirtualThreads need both can_suspend and can_support_virtual_threads
  • 00d06d4: 8289440: Remove vmTestbase/nsk/monitoring/MemoryPoolMBean/isCollectionUsageThresholdExceeded/isexceeded003 from ProblemList.txt
  • feb223a: 8288707: javax/swing/JToolBar/4529206/bug4529206.java: setFloating does not work correctly
  • c3addbb: 8288895: LdapContext doesn't honor set referrals limit
  • 1305fb5: 8287984: AArch64: [vector] Make all bits set vector sharable for match rules
  • 7b5bd25: 8286397: Address possibly lossy conversions in jdk.hotspot.agent
  • 28c5e48: 8287094: IGV: show node input numbers in edge tooltips
  • da6d1fc: 8289477: Memory corruption with CPU_ALLOC, CPU_FREE on muslc
  • ... and 13 more: https://git.openjdk.org/jdk/compare/b96ba19807845739b36274efb168dd048db819a3...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 1, 2022
@openjdk openjdk bot closed this Jul 1, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 1, 2022
@openjdk
Copy link

openjdk bot commented Jul 1, 2022

@reinrich Pushed as commit d260a4e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@reinrich reinrich deleted the 8289434_Improve_comment_on_gen_continuation_enter branch October 20, 2022 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
2 participants