Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8289534: Change 'uncomplicated' hotspot runtime options #9338

Closed
wants to merge 2 commits into from

Conversation

hseigel
Copy link
Member

@hseigel hseigel commented Jun 30, 2022

Please review this small fix to change range constrained JVM runtime options from 64 bits to 32 bits. This fix was tested with Mach5 tiers 1-2 on Linux, Mac OS, and Windows, and Mach5 tiers 3-5 on Linux x64.

Thanks, Harold


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8289534: Change 'uncomplicated' hotspot runtime options

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9338/head:pull/9338
$ git checkout pull/9338

Update a local copy of the PR:
$ git checkout pull/9338
$ git pull https://git.openjdk.org/jdk pull/9338/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9338

View PR using the GUI difftool:
$ git pr show -t 9338

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9338.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 30, 2022

👋 Welcome back hseigel! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 30, 2022
@openjdk
Copy link

openjdk bot commented Jun 30, 2022

@hseigel The following labels will be automatically applied to this pull request:

  • core-libs
  • hotspot
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability serviceability-dev@openjdk.org hotspot hotspot-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels Jun 30, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 30, 2022

Webrevs

Copy link
Contributor

@coleenp coleenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@openjdk
Copy link

openjdk bot commented Jun 30, 2022

@hseigel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289534: Change 'uncomplicated' hotspot runtime options

Reviewed-by: coleenp, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • a8fe2d9: 8289512: Fix GCC 12 warnings for adlc output_c.cpp
  • b9b900a: 8277060: EXCEPTION_INT_DIVIDE_BY_ZERO in TypeAryPtr::dump2 with -XX:+TracePhaseCCP
  • f190f4e: 8288444: Remove the workaround for frame.pack() in ModalDialogTest
  • d260a4e: 8289434: x86_64: Improve comment on gen_continuation_enter()
  • 124c63c: 8288294: [vector] Add Identity/Ideal transformations for vector logic operations
  • 918068a: Merge
  • c20b3aa: 8289278: Suspend/ResumeAllVirtualThreads need both can_suspend and can_support_virtual_threads
  • 00d06d4: 8289440: Remove vmTestbase/nsk/monitoring/MemoryPoolMBean/isCollectionUsageThresholdExceeded/isexceeded003 from ProblemList.txt

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 30, 2022
Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes seem fine, though the change to ObjectAlignmentInBytes is a bit disruptive. I don't really see a motivation for this though - the memory saving seems insignificant.

@hseigel
Copy link
Member Author

hseigel commented Jul 1, 2022

Thanks Coleen and David for the reviews!

/integrate

@openjdk
Copy link

openjdk bot commented Jul 1, 2022

Going to push as commit 09b4032.
Since your change was applied there have been 8 commits pushed to the master branch:

  • a8fe2d9: 8289512: Fix GCC 12 warnings for adlc output_c.cpp
  • b9b900a: 8277060: EXCEPTION_INT_DIVIDE_BY_ZERO in TypeAryPtr::dump2 with -XX:+TracePhaseCCP
  • f190f4e: 8288444: Remove the workaround for frame.pack() in ModalDialogTest
  • d260a4e: 8289434: x86_64: Improve comment on gen_continuation_enter()
  • 124c63c: 8288294: [vector] Add Identity/Ideal transformations for vector logic operations
  • 918068a: Merge
  • c20b3aa: 8289278: Suspend/ResumeAllVirtualThreads need both can_suspend and can_support_virtual_threads
  • 00d06d4: 8289440: Remove vmTestbase/nsk/monitoring/MemoryPoolMBean/isCollectionUsageThresholdExceeded/isexceeded003 from ProblemList.txt

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 1, 2022
@openjdk openjdk bot closed this Jul 1, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 1, 2022
@openjdk
Copy link

openjdk bot commented Jul 1, 2022

@hseigel Pushed as commit 09b4032.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

3 participants