8255595: delay_to_keep_mmu passes wrong arguments to Monitor wait

[kimbarrett]

Please review this trivial fix of the second argument in a call to MonitorLocker::wait. Because the locker is constructed as no-safepoint-checking, the improper second argument is ignored rather than possibly going into an unexpected state.

/summary Remove improper wait argument.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8255595: delay_to_keep_mmu passes wrong arguments to Monitor wait

Reviewers

• Stefan Johansson (@kstefanj - Reviewer) ⚠️ Review applies to b42f992
• Thomas Schatzl (@tschatzl - Reviewer) ⚠️ Review applies to b42f992
• Albert Mingkun Yang (@albertnetymk - Author) ⚠️ Review applies to b42f992

Download

$ git fetch https://git.openjdk.java.net/jdk pull/934/head:pull/934
$ git checkout pull/934

[bridgekeeper]

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kimbarrett Setting summary to Remove improper wait argument.

[kimbarrett]

/label add hotspot-gc

[openjdk]

@kimbarrett
The hotspot-gc label was successfully added.

[mlbridge]

Webrevs

• 01: Full - Incremental (216d75c)
• 00: Full (b42f992)

[kstefanj]

Looks good!

[openjdk]

@kimbarrett This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255595: delay_to_keep_mmu passes wrong arguments to Monitor wait

Remove improper wait argument.

Reviewed-by: sjohanss, tschatzl, ayang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tschatzl]

Lgtm and trivial.

[albertnetymk]

I wonder if it's feasible and/or worthwhile to use clang-tidy (or sth similar) to detect this kind of error in existing code and prevent it from happening again in new code.

[kimbarrett]

I wonder if it's feasible and/or worthwhile to use clang-tidy (or sth similar) to detect this kind of error in existing code and prevent it from happening again in new code.

See https://bugs.openjdk.java.net/browse/JDK-8255596

[kimbarrett]

/integrate

[openjdk]

@kimbarrett Pushed as commit 379ba80.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[albertnetymk]

See https://bugs.openjdk.java.net/browse/JDK-8255596

Thank you, Kim.