8289257: Some custom loader tests failed due to symbol refcount not decremented

[calvinccheung]

Removing the test for class loader name symbol refcount since similar test exists in runtime/ClassUnload/UnloadTest.java.

Tested locally on linux-x64 with ZGC. Running more tests via mach5.

An alternative approach would be adding a WB.fullGC() call after ClassUnloadCommon.triggerUnloading() as follows:

--- a/test/hotspot/jtreg/runtime/cds/appcds/customLoader/test-classes/HelloUnload.java
+++ b/test/hotspot/jtreg/runtime/cds/appcds/customLoader/test-classes/HelloUnload.java
@@ -105,6 +105,7 @@ public class HelloUnload {
 
             urlClassLoader = null; c = null; o = null;
             ClassUnloadCommon.triggerUnloading();
+            wb.fullGC();
             System.out.println("Is CustomLoadee alive? " + wb.isClassAlive(className));
             ClassUnloadCommon.failIf(wb.isClassAlive(className), "should have been unloaded");

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8289257: Some custom loader tests failed due to symbol refcount not decremented

Reviewers

• Ioi Lam (@iklam - Reviewer) ⚠️ Review applies to a963936c
• Coleen Phillimore (@coleenp - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9340/head:pull/9340
$ git checkout pull/9340

Update a local copy of the PR:
$ git checkout pull/9340
$ git pull https://git.openjdk.org/jdk pull/9340/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9340

View PR using the GUI difftool:
$ git pr show -t 9340

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9340.diff

[bridgekeeper]

👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[calvinccheung]

/label add hotspot-runtime

[openjdk]

@calvinccheung
The hotspot-runtime label was successfully added.

[mlbridge]

Webrevs

• 01: Full - Incremental (cbd63cdb)
• 00: Full (a963936c)

[iklam]

LGTM

[openjdk]

@calvinccheung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289257: Some custom loader tests failed due to symbol refcount not decremented

Reviewed-by: iklam, coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

• f190f4e: 8288444: Remove the workaround for frame.pack() in ModalDialogTest
• d260a4e: 8289434: x86_64: Improve comment on gen_continuation_enter()
• 124c63c: 8288294: [vector] Add Identity/Ideal transformations for vector logic operations
• 918068a: Merge
• c20b3aa: 8289278: Suspend/ResumeAllVirtualThreads need both can_suspend and can_support_virtual_threads
• 00d06d4: 8289440: Remove vmTestbase/nsk/monitoring/MemoryPoolMBean/isCollectionUsageThresholdExceeded/isexceeded003 from ProblemList.txt
• feb223a: 8288707: javax/swing/JToolBar/4529206/bug4529206.java: setFloating does not work correctly
• c3addbb: 8288895: LdapContext doesn't honor set referrals limit
• 1305fb5: 8287984: AArch64: [vector] Make all bits set vector sharable for match rules
• 7b5bd25: 8286397: Address possibly lossy conversions in jdk.hotspot.agent
• ... and 10 more: https://git.openjdk.org/jdk/compare/ba670ecbb9efdbcaa783d4a933499ca191fb58c5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[coleenp]

Yes, looks good.

[calvinccheung]

Thanks Ioi, Coleen.

/integrate

[openjdk]

Going to push as commit c43bdf7.
Since your change was applied there have been 23 commits pushed to the master branch:

• 09b4032: 8289534: Change 'uncomplicated' hotspot runtime options
• a8fe2d9: 8289512: Fix GCC 12 warnings for adlc output_c.cpp
• b9b900a: 8277060: EXCEPTION_INT_DIVIDE_BY_ZERO in TypeAryPtr::dump2 with -XX:+TracePhaseCCP
• f190f4e: 8288444: Remove the workaround for frame.pack() in ModalDialogTest
• d260a4e: 8289434: x86_64: Improve comment on gen_continuation_enter()
• 124c63c: 8288294: [vector] Add Identity/Ideal transformations for vector logic operations
• 918068a: Merge
• c20b3aa: 8289278: Suspend/ResumeAllVirtualThreads need both can_suspend and can_support_virtual_threads
• 00d06d4: 8289440: Remove vmTestbase/nsk/monitoring/MemoryPoolMBean/isCollectionUsageThresholdExceeded/isexceeded003 from ProblemList.txt
• feb223a: 8288707: javax/swing/JToolBar/4529206/bug4529206.java: setFloating does not work correctly
• ... and 13 more: https://git.openjdk.org/jdk/compare/ba670ecbb9efdbcaa783d4a933499ca191fb58c5...master

Your commit was automatically rebased without conflicts.

[openjdk]

@calvinccheung Pushed as commit c43bdf7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.