8289584: (fs) Print size values in java/nio/file/FileStore/Basic.java when they differ by > 1GiB

[bplb]

The test fails when an expected size is greater than 1 GiB but there is no indication of how much the size deviates from the expected value. This information might be helpful in adjusting the threshold.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8289584: (fs) Print size values in java/nio/file/FileStore/Basic.java when they differ by > 1GiB

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9347/head:pull/9347
$ git checkout pull/9347

Update a local copy of the PR:
$ git checkout pull/9347
$ git pull https://git.openjdk.org/jdk pull/9347/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9347

View PR using the GUI difftool:
$ git pr show -t 9347

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9347.diff

[bridgekeeper]

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@bplb The following label will be automatically applied to this pull request:

• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (2f3fd68f)

[openjdk]

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289584: (fs) Print size values in java/nio/file/FileStore/Basic.java when they differ by > 1GiB

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[bplb]

/integrate

[openjdk]

Going to push as commit e291a67.
Since your change was applied there has been 1 commit pushed to the master branch:

• c43bdf7: 8289257: Some custom loader tests failed due to symbol refcount not decremented

Your commit was automatically rebased without conflicts.

[openjdk]

@bplb Pushed as commit e291a67.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.