-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8282730: LdapLoginModule throw NPE from logout method after login failure #9348
Conversation
👋 Welcome back weijun! A progress list of the required criteria for merging this PR into |
src/jdk.security.auth/share/classes/com/sun/security/auth/module/NTLoginModule.java
Outdated
Show resolved
Hide resolved
src/jdk.security.auth/share/classes/com/sun/security/auth/module/JndiLoginModule.java
Outdated
Show resolved
Hide resolved
/csr |
@wangweij has indicated that a compatibility and specification (CSR) request is needed for this pull request. @wangweij please create a CSR request for issue JDK-8282730 with the correct fix version. This pull request cannot be integrated until the CSR request is approved. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor comments so far; still reviewing.
src/jdk.security.auth/share/classes/com/sun/security/auth/module/UnixLoginModule.java
Outdated
Show resolved
Hide resolved
src/jdk.security.auth/share/classes/com/sun/security/auth/module/JndiLoginModule.java
Outdated
Show resolved
Hide resolved
src/java.base/share/classes/javax/security/auth/spi/LoginModule.java
Outdated
Show resolved
Hide resolved
src/java.base/share/classes/javax/security/auth/spi/LoginModule.java
Outdated
Show resolved
Hide resolved
New commits pushed. BTW, in the 2nd one, I reverted some |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can also review the CSR when it is ready.
Thanks. CSR is filed at https://bugs.openjdk.org/browse/JDK-8290119. I've also written a release note at https://bugs.openjdk.org/browse/JDK-8290467. Please take a review. |
@wangweij This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 434 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 554f44e.
Your commit was automatically rebased without conflicts. |
Add null-checks in all
LoginModule
implementations. It's possible that an application callslogout
after a login failure, where most internal variables for principals and credentials are null and removing a null from theSubject
's principals and credentials sets will trigger aNullPointerException
.Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9348/head:pull/9348
$ git checkout pull/9348
Update a local copy of the PR:
$ git checkout pull/9348
$ git pull https://git.openjdk.org/jdk pull/9348/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 9348
View PR using the GUI difftool:
$ git pr show -t 9348
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9348.diff