JDK-8289741 : Remove unused imports from DTDBuilder.java #9360

scientificware · 2022-07-04T07:04:40Z

This is tracked in JBS as

JDK-8289741 and duplicated by JDK-8290070

Unused imports in DTDBuider.java.

Remove unused imports from DTDBuilder.java

Some imports are no more used.

java.io.FileNotFoundException;
java.io.BufferedInputStream;
java.io.OutputStream;
java.util.BitSet;
java.util.StringTokenizer;
java.util.Properties;
java.util.zip.DeflaterOutputStream;
java.util.zip.Deflater;
java.net.URL;

scientificware#4

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8289741: Remove unused imports from DTDBuilder.java

Reviewers

Jaikiran Pai (@jaikiran - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9360/head:pull/9360
$ git checkout pull/9360

Update a local copy of the PR:
$ git checkout pull/9360
$ git pull https://git.openjdk.org/jdk pull/9360/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9360

View PR using the GUI difftool:
$ git pr show -t 9360

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9360.diff

Some imports are no more used. - java.io.FileNotFoundException; - java.io.BufferedInputStream; - java.io.OutputStream; - java.util.BitSet; - java.util.StringTokenizer; - java.util.Properties; - java.util.zip.DeflaterOutputStream; - java.util.zip.Deflater; - java.net.URL;

bridgekeeper · 2022-07-04T07:05:42Z

👋 Welcome back scientificware! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2022-07-04T07:07:14Z

@scientificware The following labels will be automatically applied to this pull request:

build
core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

TheShermanTanker · 2022-07-05T01:53:33Z

@scientificware Do you need an entry in the JBS for this PR?

scientificware · 2022-07-05T03:12:30Z

Hi @TheShermanTanker,
Yes I need it.
I'm waiting for the Issue Id.
Regards

TheShermanTanker · 2022-07-05T03:40:51Z

Alright, was asking since I can help create one for you, but it seems that others already have it covered

scientificware · 2022-07-05T05:18:01Z

@TheShermanTanker , thank you for asking and helping.

it seems that others already have it covered

In fact, I don't known.
Yesterday, I posted 3 reports in the Java Bug Database and I have no feedback at this moment.

TheShermanTanker · 2022-07-05T11:34:05Z

@TheShermanTanker , thank you for asking and helping.

it seems that others already have it covered

In fact, I dont known. Yesterday, I posted 3 reports in the Java Bug Database and I have no feedback at this moment.

Well, in that case, wait no longer!
Your issue ID is 8289741, just change your title to "8289741" and the automated tooling should take care of the rest and send this PR to the appropriate teams for review.

All the best!

mlbridge · 2022-07-05T12:19:17Z

Webrevs

scientificware · 2022-07-05T12:33:35Z

@TheShermanTanker Thanks.

magicus · 2022-07-06T16:39:57Z

/label -build

openjdk · 2022-07-06T16:41:13Z

@magicus
The build label was successfully removed.

bridgekeeper · 2022-08-04T04:06:00Z

@scientificware This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

scientificware · 2022-08-04T06:25:27Z

Just waiting to be reviewed.

jaikiran · 2022-08-05T07:56:40Z

I see that the changed file resides at make/jdk/src/classes/build/tools/dtdbuilder/DTDBuilder.java and I think this needs to be reviewed by the build team. @magicus, is it OK if I re-add the build label for this PR?

scientificware · 2022-08-05T09:02:44Z

Hello @jaikiran, the copyright years were updated by a previous commit.

jaikiran · 2022-08-05T09:55:58Z

You are right, the copyright year on the file is fine - I was looking at an older version of this file.

magicus · 2022-08-08T08:46:05Z

@jaikiran The build tools are not really part of the build system as such. I used to push for a solution to move them to their corresponding modules, but this met with resistance and did not really go anywhere.

In general, though, the build tools needs to be reviewed by the group "owning" them. In some cases, the change affects how the build tool interacts with the rest of the build system. If that is the case, the build label is relevant.

Unfortunately, the Skara label rules are a bit too coarse to capture this reality.

jaikiran · 2022-08-09T02:36:16Z

Thank you Magnus.

Given the nature of this change, adding myself as the reviewer and approving this change.

jaikiran · 2022-08-09T02:37:21Z

@scientificware, please issue the integrate command when you are ready and I can sponsor this for you. In the meantime, I'll run some tests to be sure that this change is fine.

openjdk · 2022-08-09T02:53:02Z

@scientificware This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289741: Remove unused imports from DTDBuilder.java

Reviewed-by: jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

af243ca: 8265433: IGV: add graph tooltips with properties
7739843: 8288633: The ICC_ColorSpace.fromCIEXYZ method uses the wrong rendering intent
eb8b789: 8292061: ProblemList serviceability/attach/ConcAttachTest.java on linux-all
08274e6: 8290975: Minor cleanup could be done in javax.security
7db5abd: 8282642: vmTestbase/gc/gctests/LoadUnloadGC2/LoadUnloadGC2.java fails intermittently with exit code 1
124fc4a: 8290180: Convert com/sun/management/UnixOperatingSystemMXBean/GetOpenFileDescriptorCount.sh to jtreg java version
4591937: 8290357: Drop HeapRegion::marked_bytes()
7676be8: 8291037: Move PLAB resizing mechanism to G1EvacStats
861cc67: 8291897: TerminatingThreadLocal(s) not registered from virtual thread(s)
8d88be2: 8291459: JVM crash with GenerateOopMap::error_work(char const*, __va_list_tag*)
... and 17 more: https://git.openjdk.org/jdk/compare/dd7f2d912bb66c0f10d7165040e52e2d18b73897...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jaikiran) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

scientificware · 2022-08-09T08:25:40Z

/integrate

openjdk · 2022-08-09T08:27:00Z

@scientificware
Your change (at version ea24346) is now ready to be sponsored by a Committer.

scientificware · 2022-08-09T08:31:03Z

@jaikiran, Done and thanks for your sponsoring and reviewing.

jaikiran · 2022-08-09T08:38:26Z

The tests came back fine without any issue.

jaikiran · 2022-08-09T08:38:31Z

/sponsor

openjdk · 2022-08-09T08:40:36Z

Going to push as commit 2712bc3.
Since your change was applied there have been 27 commits pushed to the master branch:

af243ca: 8265433: IGV: add graph tooltips with properties
7739843: 8288633: The ICC_ColorSpace.fromCIEXYZ method uses the wrong rendering intent
eb8b789: 8292061: ProblemList serviceability/attach/ConcAttachTest.java on linux-all
08274e6: 8290975: Minor cleanup could be done in javax.security
7db5abd: 8282642: vmTestbase/gc/gctests/LoadUnloadGC2/LoadUnloadGC2.java fails intermittently with exit code 1
124fc4a: 8290180: Convert com/sun/management/UnixOperatingSystemMXBean/GetOpenFileDescriptorCount.sh to jtreg java version
4591937: 8290357: Drop HeapRegion::marked_bytes()
7676be8: 8291037: Move PLAB resizing mechanism to G1EvacStats
861cc67: 8291897: TerminatingThreadLocal(s) not registered from virtual thread(s)
8d88be2: 8291459: JVM crash with GenerateOopMap::error_work(char const*, __va_list_tag*)
... and 17 more: https://git.openjdk.org/jdk/compare/dd7f2d912bb66c0f10d7165040e52e2d18b73897...master

Your commit was automatically rebased without conflicts.

openjdk · 2022-08-09T08:41:00Z

@jaikiran @scientificware Pushed as commit 2712bc3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

scientificware · 2022-08-09T08:51:01Z

@jaikiran Great Thanks.

scientificware added 3 commits July 4, 2022 00:46

Merge branch 'openjdk:master' into scientificware-patch-001-DTDBuilder

3a442d1

Merge branch 'openjdk:master' into scientificware-patch-001-DTDBuilder

283eddd

openjdk bot added build build-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels Jul 4, 2022

Merge branch 'openjdk:master' into scientificware-patch-001-DTDBuilder

fbff7db

scientificware mentioned this pull request Jul 4, 2022

JDK-8289741 : DTDBuilder.java unused imports. scientificware/jdk#4

Open

scientificware added 3 commits July 4, 2022 16:13

Merge branch 'openjdk:master' into scientificware-patch-001-DTDBuilder

437aea1

Merge branch 'openjdk:master' into scientificware-patch-001-DTDBuilder

e8c8602

Merge branch 'openjdk:master' into scientificware-patch-001-DTDBuilder

2bf7971

scientificware changed the title ~~Remove unused imports.~~ JDK-8289741 : Remove unused imports from DTDBuilder.java Jul 5, 2022

openjdk bot added the rfr Pull request is ready for review label Jul 5, 2022

openjdk bot removed the build build-dev@openjdk.org label Jul 6, 2022

Merge branch 'openjdk:master' into scientificware-patch-001-DTDBuilder

6d097e7

Merge branch 'openjdk:master' into scientificware-patch-001-DTDBuilder

ea24346

jaikiran approved these changes Aug 9, 2022

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Aug 9, 2022

openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 9, 2022

openjdk bot added the integrated Pull request has been integrated label Aug 9, 2022

openjdk bot closed this Aug 9, 2022

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 9, 2022

JDK-8289741 : Remove unused imports from DTDBuilder.java #9360

JDK-8289741 : Remove unused imports from DTDBuilder.java #9360

Uh oh!

Conversation

scientificware commented Jul 4, 2022 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Jul 4, 2022

Uh oh!

openjdk bot commented Jul 4, 2022

Uh oh!

TheShermanTanker commented Jul 5, 2022

Uh oh!

scientificware commented Jul 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TheShermanTanker commented Jul 5, 2022

Uh oh!

scientificware commented Jul 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TheShermanTanker commented Jul 5, 2022

Uh oh!

mlbridge bot commented Jul 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

scientificware commented Jul 5, 2022

Uh oh!

magicus commented Jul 6, 2022

Uh oh!

openjdk bot commented Jul 6, 2022

Uh oh!

bridgekeeper bot commented Aug 4, 2022

Uh oh!

scientificware commented Aug 4, 2022

Uh oh!

jaikiran commented Aug 5, 2022

Uh oh!

scientificware commented Aug 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jaikiran commented Aug 5, 2022

Uh oh!

magicus commented Aug 8, 2022

Uh oh!

jaikiran commented Aug 9, 2022

Uh oh!

jaikiran commented Aug 9, 2022

Uh oh!

openjdk bot commented Aug 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

scientificware commented Aug 9, 2022

Uh oh!

openjdk bot commented Aug 9, 2022

Uh oh!

scientificware commented Aug 9, 2022

Uh oh!

jaikiran commented Aug 9, 2022

Uh oh!

jaikiran commented Aug 9, 2022

Uh oh!

openjdk bot commented Aug 9, 2022

Uh oh!

openjdk bot commented Aug 9, 2022

Uh oh!

scientificware commented Aug 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

scientificware commented Jul 4, 2022 •

edited by openjdk bot

Loading

scientificware commented Jul 5, 2022 •

edited

Loading

scientificware commented Jul 5, 2022 •

edited

Loading

mlbridge bot commented Jul 5, 2022 •

edited

Loading

scientificware commented Aug 5, 2022 •

edited

Loading

openjdk bot commented Aug 9, 2022 •

edited

Loading

scientificware commented Aug 9, 2022 •

edited

Loading