Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8289617: Remove test/jdk/java/net/ServerSocket/ThreadStop.java #9365

Closed
wants to merge 1 commit into from

Conversation

Michael-Mc-Mahon
Copy link
Member

@Michael-Mc-Mahon Michael-Mc-Mahon commented Jul 4, 2022

Hi,

Could I get the following small change reviewed please?

It removes a test that calls Thread.stop() which is no longer required since it was checking for
a bug in the old SocketImpl that has recently been replaced by the NIO implementation.

Thanks,
Michael.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8289617: Remove test/jdk/java/net/ServerSocket/ThreadStop.java

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9365/head:pull/9365
$ git checkout pull/9365

Update a local copy of the PR:
$ git checkout pull/9365
$ git pull https://git.openjdk.org/jdk pull/9365/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9365

View PR using the GUI difftool:
$ git pr show -t 9365

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9365.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 4, 2022

👋 Welcome back michaelm! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 4, 2022
@openjdk
Copy link

openjdk bot commented Jul 4, 2022

@Michael-Mc-Mahon The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the net net-dev@openjdk.org label Jul 4, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 4, 2022

Webrevs

Copy link
Contributor

@AlanBateman AlanBateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No value keeping this test.

@openjdk
Copy link

openjdk bot commented Jul 4, 2022

@Michael-Mc-Mahon This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289617: Remove test/jdk/java/net/ServerSocket/ThreadStop.java

Reviewed-by: alanb, jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 688712f: 8289633: Forbid raw C-heap allocation functions in hotspot and fix findings
  • df063f7: 8289484: Cleanup unnecessary null comparison before instanceof check in java.rmi
  • 9ccae70: 8287593: ShortResponseBody could be made more resilient to rogue connections
  • bad9ffe: 8288947: G1: Consolidate per-region is-humongous query in G1CollectedHeap
  • b5d9656: 8288971: AArch64: Clean up stack and register handling in interpreter
  • d53b02e: 8287312: G1: Early return on first failure in VerifyRegionClosure

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 4, 2022
@Michael-Mc-Mahon
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 5, 2022

Going to push as commit 77c3bbf.
Since your change was applied there have been 10 commits pushed to the master branch:

  • a5934cd: 8289698: AArch64: Need to relativize extended_sp in frame
  • fd1bb07: 8287603: Avoid redundant HashMap.containsKey calls in NimbusDefaults.getDerivedColor
  • 4c997ba: 8289520: G1: Remove duplicate checks in G1BarrierSetC1::post_barrier
  • 1b997db: 8289427: compiler/compilercontrol/jcmd/ClearDirectivesFileStackTest.java failed with null setting
  • 688712f: 8289633: Forbid raw C-heap allocation functions in hotspot and fix findings
  • df063f7: 8289484: Cleanup unnecessary null comparison before instanceof check in java.rmi
  • 9ccae70: 8287593: ShortResponseBody could be made more resilient to rogue connections
  • bad9ffe: 8288947: G1: Consolidate per-region is-humongous query in G1CollectedHeap
  • b5d9656: 8288971: AArch64: Clean up stack and register handling in interpreter
  • d53b02e: 8287312: G1: Early return on first failure in VerifyRegionClosure

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 5, 2022
@openjdk openjdk bot closed this Jul 5, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 5, 2022
@openjdk
Copy link

openjdk bot commented Jul 5, 2022

@Michael-Mc-Mahon Pushed as commit 77c3bbf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Michael-Mc-Mahon Michael-Mc-Mahon deleted the testcase branch July 5, 2022 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated net net-dev@openjdk.org
3 participants