Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8289804: Remove redundant stream() call before forEach in jdk.jshell #9370

Conversation

turbanoff
Copy link
Member

@turbanoff turbanoff commented Jul 4, 2022

There are several places in the jdk.jshell implementation that use stream().forEach(...), these can be cleaned up.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8289804: Remove redundant stream() call before forEach in jdk.jshell

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9370/head:pull/9370
$ git checkout pull/9370

Update a local copy of the PR:
$ git checkout pull/9370
$ git pull https://git.openjdk.org/jdk pull/9370/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9370

View PR using the GUI difftool:
$ git pr show -t 9370

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9370.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 4, 2022

👋 Welcome back aturbanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 4, 2022

@turbanoff The following label will be automatically applied to this pull request:

  • kulla

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the kulla kulla-dev@openjdk.org label Jul 4, 2022
@turbanoff turbanoff changed the title [PATCH] Remove redundant stream() call before forEach in jdk.jshell 8289804: Remove redundant stream() call before forEach in jdk.jshell Jul 6, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 6, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 6, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 7, 2022

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289804: Remove redundant stream() call before forEach in jdk.jshell

Reviewed-by: psandoz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 55 new commits pushed to the master branch:

  • 8cdead0: 8278923: Document Klass::is_loader_alive
  • f93beac: 8252329: runtime/LoadClass/TestResize.java timed out
  • 3e60e82: 8289301: P11Cipher should not throw out of bounds exception during padding
  • f7b1830: 8289538: Make G1BlockOffsetTablePart unaware of block sizes
  • 5564eff: 8289763: Remove NULL check in CDSProtectionDomain::init_security_info()
  • a694e9e: 8288838: jpackage: file association additional arguments
  • 95e3190: 8210708: Use single mark bitmap in G1
  • 8e7b45b: 8282986: Remove "system" in boot class path names
  • 74ca6ca: 8289800: G1: G1CollectionSet::finalize_young_part clears survivor list too early
  • 86f63f9: 8289164: Convert ResolutionErrorTable to use ResourceHashtable
  • ... and 45 more: https://git.openjdk.org/jdk/compare/df063f7db18a40ea7325fe608b3206a6dff812c1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 7, 2022
@turbanoff
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 19, 2022

Going to push as commit 2ff2208.
Since your change was applied there have been 199 commits pushed to the master branch:

  • f5a7de8: 8290379: Parse error with parenthesized pattern and guard using an array
  • 612d8c6: 8290456: remove os::print_statistics()
  • d7f0de2: 8290460: Alpine: disable some panama tests that rely on std::thread
  • dfbc691: 8289524: Add JFR JIT restart event
  • 4e6cd67: 8290000: Bump macOS GitHub actions to macOS 11
  • af86cd3: 8290463: Fix several comment typos in sun.security.ec
  • 6cd1c0c: Merge
  • 2677dd6: 8289954: C2: Assert failed in PhaseCFG::verify() after JDK-8183390
  • 4f3f74c: 8289127: Apache Lucene triggers: DEBUG MESSAGE: duplicated predicate failed which is impossible
  • 4a4d8ed: 8289801: [IR Framework] Add flags to whitelist which can be used to simulate a specific machine setup like UseAVX
  • ... and 189 more: https://git.openjdk.org/jdk/compare/df063f7db18a40ea7325fe608b3206a6dff812c1...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 19, 2022
@openjdk openjdk bot closed this Jul 19, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 19, 2022
@openjdk
Copy link

openjdk bot commented Jul 19, 2022

@turbanoff Pushed as commit 2ff2208.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@turbanoff turbanoff deleted the redundant_stream_before_forEach_jdk.jshell branch October 27, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated kulla kulla-dev@openjdk.org
2 participants