Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8289740: Add verification testing during all concurrent phases in G1 #9377

Closed

Conversation

tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Jul 5, 2022

Hi all,

can I have reviews for this change that adds a test that causes GCs that do lots of verification in all phases of the concurrent cycle to make sure that verification is working after changes.

Testing: test case, gha

Thanks,
Thomas


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8289740: Add verification testing during all concurrent phases in G1

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9377/head:pull/9377
$ git checkout pull/9377

Update a local copy of the PR:
$ git checkout pull/9377
$ git pull https://git.openjdk.org/jdk pull/9377/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9377

View PR using the GUI difftool:
$ git pr show -t 9377

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9377.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 5, 2022

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into pr/9376 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8289740 8289740: Add verification testing during all concurrent phases in G1 Jul 5, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 5, 2022
@openjdk
Copy link

openjdk bot commented Jul 5, 2022

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Jul 5, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 5, 2022

Webrevs

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/9376 to master July 6, 2022 09:45
@openjdk-notifier
Copy link

The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout submit/8289740-verification-cycle2
git fetch https://git.openjdk.org/jdk master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

Copy link
Member

@walulyai walulyai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@openjdk
Copy link

openjdk bot commented Jul 7, 2022

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289740: Add verification testing during all concurrent phases in G1

Reviewed-by: iwalulya, ayang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 3e60e82: 8289301: P11Cipher should not throw out of bounds exception during padding
  • f7b1830: 8289538: Make G1BlockOffsetTablePart unaware of block sizes
  • 5564eff: 8289763: Remove NULL check in CDSProtectionDomain::init_security_info()
  • a694e9e: 8288838: jpackage: file association additional arguments

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 7, 2022
@tschatzl
Copy link
Contributor Author

tschatzl commented Jul 8, 2022

Thanks @walulyai @albertnetymk for your reviews.

/integrate

@openjdk
Copy link

openjdk bot commented Jul 8, 2022

Going to push as commit 1b8f466.
Since your change was applied there have been 20 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 8, 2022
@openjdk openjdk bot closed this Jul 8, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 8, 2022
@openjdk
Copy link

openjdk bot commented Jul 8, 2022

@tschatzl Pushed as commit 1b8f466.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tschatzl tschatzl deleted the submit/8289740-verification-cycle2 branch July 8, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
3 participants