Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8289745: JfrStructCopyFailed uses heap words instead of bytes for object sizes #9378

Closed
wants to merge 1 commit into from

Conversation

schmelter-sap
Copy link
Contributor

@schmelter-sap schmelter-sap commented Jul 5, 2022

The values for smallestSize, firstSize and totalSize in the CopyFailed type are set as the number of heap words, but should be number of bytes. This leads to wrong values in the PromotionFailed and EvacuationFailed JFR events containing this type.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8289745: JfrStructCopyFailed uses heap words instead of bytes for object sizes

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9378/head:pull/9378
$ git checkout pull/9378

Update a local copy of the PR:
$ git checkout pull/9378
$ git pull https://git.openjdk.org/jdk pull/9378/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9378

View PR using the GUI difftool:
$ git pr show -t 9378

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9378.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 5, 2022

👋 Welcome back rschmelter! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title JDK-8289745: JfrStructCopyFailed uses heap words instead of bytes 8289745: JfrStructCopyFailed uses heap words instead of bytes for object sizes Jul 5, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 5, 2022
@openjdk
Copy link

openjdk bot commented Jul 5, 2022

@schmelter-sap The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Jul 5, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 5, 2022

Webrevs

@mgronlun
Copy link

mgronlun commented Jul 6, 2022

Great Ralf, thank you for finding and fixing this.

@openjdk
Copy link

openjdk bot commented Jul 6, 2022

@schmelter-sap This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289745: JfrStructCopyFailed uses heap words instead of bytes for object sizes

Reviewed-by: mgronlun, stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • 75c0a5b: 8288824: [arm32] Display isetstate in register output
  • 83a5d59: 8278479: RunThese test failure with +UseHeavyMonitors and +VerifyHeavyMonitors
  • cbaf6e8: 8288022: c2: Transform (CastLL (AddL into (AddL (CastLL when possible
  • 8341895: 8289739: Add G1 specific GC breakpoints for testing
  • ac6be16: 8289695: [TESTBUG] TestMemoryAwareness.java fails on cgroups v2 and crun
  • 4ad18cf: 8289730: Deprecated code sample in java.lang.ClassCastException
  • d8f4e97: 8289146: containers/docker/TestMemoryWithCgroupV1.java fails on linux ppc64le machine with missing Memory and Swap Limit output
  • f783244: 8289706: (cs) Avoid redundant TreeMap.containsKey call in AbstractCharsetProvider
  • fafe8b3: 8289604: compiler/vectorapi/VectorLogicalOpIdentityTest.java failed on x86 AVX1 system
  • 3515604: 8280481: Duplicated stubs to interpreter for static calls
  • ... and 2 more: https://git.openjdk.org/jdk/compare/77c3bbf105403089fec69d51406fe3e6f562271f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 6, 2022
Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. IIUC this issue is a day zero bug, right? Bit scary that this was not found before.

@schmelter-sap
Copy link
Contributor Author

Thanks for the reviews

@schmelter-sap
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 12, 2022

Going to push as commit 7f0e9bd.
Since your change was applied there have been 112 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 12, 2022
@openjdk openjdk bot closed this Jul 12, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 12, 2022
@openjdk
Copy link

openjdk bot commented Jul 12, 2022

@schmelter-sap Pushed as commit 7f0e9bd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@schmelter-sap schmelter-sap deleted the JDK-8289745 branch July 27, 2022 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
3 participants