8288706: Unused parameter 'boolean newln' in method java.lang.VersionProps#print(boolean, boolean)

[LanceAndersen]

Hi all,

This PR cleans up VersionProps::print removing the unused parameter newln.

Mach5 tiers1-3 are currently running.

Best,
Lance

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8288706: Unused parameter 'boolean newln' in method java.lang.VersionProps#print(boolean, boolean)

Reviewers

• Iris Clark (@irisclark - Reviewer)
• Alan Bateman (@AlanBateman - Reviewer)
• Roger Riggs (@RogerRiggs - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9382/head:pull/9382
$ git checkout pull/9382

Update a local copy of the PR:
$ git checkout pull/9382
$ git pull https://git.openjdk.org/jdk pull/9382/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9382

View PR using the GUI difftool:
$ git pr show -t 9382

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9382.diff

[bridgekeeper]

👋 Welcome back lancea! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@LanceAndersen The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (55bf8ed4)

[openjdk]

@LanceAndersen This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288706: Unused parameter 'boolean newln' in method java.lang.VersionProps#print(boolean, boolean)

Reviewed-by: iris, alanb, rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 146 new commits pushed to the master branch:

• 82a8bd7: 8287596: Reorg jdk.test.lib.util.ForceGC
• cc2b792: 8288992: AArch64: CMN should be handled the same way as CMP
• 75c0a5b: 8288824: [arm32] Display isetstate in register output
• 83a5d59: 8278479: RunThese test failure with +UseHeavyMonitors and +VerifyHeavyMonitors
• cbaf6e8: 8288022: c2: Transform (CastLL (AddL into (AddL (CastLL when possible
• 8341895: 8289739: Add G1 specific GC breakpoints for testing
• ac6be16: 8289695: [TESTBUG] TestMemoryAwareness.java fails on cgroups v2 and crun
• 4ad18cf: 8289730: Deprecated code sample in java.lang.ClassCastException
• d8f4e97: 8289146: containers/docker/TestMemoryWithCgroupV1.java fails on linux ppc64le machine with missing Memory and Swap Limit output
• f783244: 8289706: (cs) Avoid redundant TreeMap.containsKey call in AbstractCharsetProvider
• ... and 136 more: https://git.openjdk.org/jdk/compare/b206d2d14937bf8cfebb629888a09311275ac0db...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[LanceAndersen]

/integrate

[openjdk]

Going to push as commit 9f37ba4.
Since your change was applied there have been 147 commits pushed to the master branch:

• dfb24ae: 8289060: Undefined Behaviour in class VMReg
• 82a8bd7: 8287596: Reorg jdk.test.lib.util.ForceGC
• cc2b792: 8288992: AArch64: CMN should be handled the same way as CMP
• 75c0a5b: 8288824: [arm32] Display isetstate in register output
• 83a5d59: 8278479: RunThese test failure with +UseHeavyMonitors and +VerifyHeavyMonitors
• cbaf6e8: 8288022: c2: Transform (CastLL (AddL into (AddL (CastLL when possible
• 8341895: 8289739: Add G1 specific GC breakpoints for testing
• ac6be16: 8289695: [TESTBUG] TestMemoryAwareness.java fails on cgroups v2 and crun
• 4ad18cf: 8289730: Deprecated code sample in java.lang.ClassCastException
• d8f4e97: 8289146: containers/docker/TestMemoryWithCgroupV1.java fails on linux ppc64le machine with missing Memory and Swap Limit output
• ... and 137 more: https://git.openjdk.org/jdk/compare/b206d2d14937bf8cfebb629888a09311275ac0db...master

Your commit was automatically rebased without conflicts.

[openjdk]

@LanceAndersen Pushed as commit 9f37ba4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.