8255604: java/nio/channels/DatagramChannel/Connect.java fails with java.net.BindException: Cannot assign requested address: connect

[c-cleary]

Recent fixes to Connect.java caused tier2 test failures on windows-x64 operating systems. This was caused by the Actor in the test attempting to connect to a wildcard address which it attained from the Reactor's getSocketAddress(), which in turn was set to the wildcard address in the Reactor constructor. This has been fixed by using the loopback address and an ephermal port number (0) int the Reactor's bind() operation.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Testing

	Linux x64	Linux x86	Windows x64	macOS x64
Build	✔️ (5/5 passed)	✔️ (2/2 passed)	✔️ (2/2 passed)	✔️ (2/2 passed)
Test (tier1)	✔️ (9/9 passed)	✔️ (9/9 passed)	⏳ (7/9 running)	⏳ (6/9 running)

Issue

• JDK-8255604: java/nio/channels/DatagramChannel/Connect.java fails with java.net.BindException: Cannot assign requested address: connect

Reviewers

• Daniel Fuchs (@dfuch - Reviewer)
• Michael McMahon (@Michael-Mc-Mahon - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/939/head:pull/939
$ git checkout pull/939

[bridgekeeper]

👋 Welcome back ccleary! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@ccleary-oracle The following label will be automatically applied to this pull request:

• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[dfuch]

That looks good to me Conor.

[openjdk]

@ccleary-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255604: java/nio/channels/DatagramChannel/Connect.java fails with java.net.BindException: Cannot assign requested address: connect

Reviewed-by: dfuchs, michaelm

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• 2a2fa13: 8255449: Improve the exception message of MethodHandles::permuteArguments
• 2a50c3f: 8241495: Make more compiler related flags available on a per method level

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dfuch, @Michael-Mc-Mahon) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 00: Full (3cfee7d)

[c-cleary]

/integrate

[openjdk]

@ccleary-oracle
Your change (at version 3cfee7d) is now ready to be sponsored by a Committer.

[dfuch]

/sponsor

[openjdk]

@dfuch @ccleary-oracle Since your change was applied there have been 2 commits pushed to the master branch:

• 2a2fa13: 8255449: Improve the exception message of MethodHandles::permuteArguments
• 2a50c3f: 8241495: Make more compiler related flags available on a per method level

Your commit was automatically rebased without conflicts.

Pushed as commit d5138d1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.