8252329: runtime/LoadClass/TestResize.java timed out

[coleenp]

This test loads 50k classes and then does PrintSystemDictionaryAtExit. The timeout seems to be during processing the output to find the load factor of the dictionary. I reduced the number of classes to 30K, which causes the one resize, and added the output to PrintClassLoaderDataAtExit, which is only 100 lines of output vs. 51000 lines of output.
I also added Verbose to PrintClassLoaderDataAtExit to print all the classes, since if you really want all the classes, you should use PrintSystemDictionaryAtExit.
Tested with tier1.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8252329: runtime/LoadClass/TestResize.java timed out

Reviewers

• Harold Seigel (@hseigel - Reviewer) ⚠️ Review applies to 1181c82f
• Ioi Lam (@iklam - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9394/head:pull/9394
$ git checkout pull/9394

Update a local copy of the PR:
$ git checkout pull/9394
$ git pull https://git.openjdk.org/jdk pull/9394/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9394

View PR using the GUI difftool:
$ git pr show -t 9394

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9394.diff

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (39a0b5f7)
• 01: Full - Incremental (1181c82f)
• 00: Full (3611b1de)

[hseigel]

Changes look good!
Thanks, Harold

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8252329: runtime/LoadClass/TestResize.java timed out

Reviewed-by: hseigel, iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 76 new commits pushed to the master branch:

• 3e60e82: 8289301: P11Cipher should not throw out of bounds exception during padding
• f7b1830: 8289538: Make G1BlockOffsetTablePart unaware of block sizes
• 5564eff: 8289763: Remove NULL check in CDSProtectionDomain::init_security_info()
• a694e9e: 8288838: jpackage: file association additional arguments
• 95e3190: 8210708: Use single mark bitmap in G1
• 8e7b45b: 8282986: Remove "system" in boot class path names
• 74ca6ca: 8289800: G1: G1CollectionSet::finalize_young_part clears survivor list too early
• 86f63f9: 8289164: Convert ResolutionErrorTable to use ResourceHashtable
• 013a5ee: 8137280: Remove eager reclaim of humongous controls
• 77ad998: 8289778: ZGC: incorrect use of os::free() for mountpoint string handling after JDK-8289633
• ... and 66 more: https://git.openjdk.org/jdk/compare/e291a67e96970d80a9915f8a23afffed6e0b8ded...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[iklam]

The latest version looks good to me.

[coleenp]

Thanks Harold and Ioi, and thanks for pointing out the test needed work.
/integrate

[openjdk]

Going to push as commit f93beac.
Since your change was applied there have been 76 commits pushed to the master branch:

• 3e60e82: 8289301: P11Cipher should not throw out of bounds exception during padding
• f7b1830: 8289538: Make G1BlockOffsetTablePart unaware of block sizes
• 5564eff: 8289763: Remove NULL check in CDSProtectionDomain::init_security_info()
• a694e9e: 8288838: jpackage: file association additional arguments
• 95e3190: 8210708: Use single mark bitmap in G1
• 8e7b45b: 8282986: Remove "system" in boot class path names
• 74ca6ca: 8289800: G1: G1CollectionSet::finalize_young_part clears survivor list too early
• 86f63f9: 8289164: Convert ResolutionErrorTable to use ResourceHashtable
• 013a5ee: 8137280: Remove eager reclaim of humongous controls
• 77ad998: 8289778: ZGC: incorrect use of os::free() for mountpoint string handling after JDK-8289633
• ... and 66 more: https://git.openjdk.org/jdk/compare/e291a67e96970d80a9915f8a23afffed6e0b8ded...master

Your commit was automatically rebased without conflicts.

[openjdk]

@coleenp Pushed as commit f93beac.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.