JDK-8254920: Application launched with jpackage produced .exe crashes JVM

[andyherrick]

JVM

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Testing

	Linux x64	Linux x86	Windows x64	macOS x64
Build	✔️ (5/5 passed)	✔️ (2/2 passed)	✔️ (2/2 passed)	✔️ (2/2 passed)
Test (tier1)	✔️ (9/9 passed)	✔️ (9/9 passed)	✔️ (9/9 passed)	✔️ (9/9 passed)

Issue

• JDK-8254920: Application launched with jpackage produced .exe crashes JVM

Reviewers

• Alexey Semenyuk (@alexeysemenyukoracle - Committer) ⚠️ Review applies to 3d83b99
• Alexander Matveev (@sashamatveev - Committer) ⚠️ Review applies to 3d83b99
• Alexander Zuev (@azuev-java - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/940/head:pull/940
$ git checkout pull/940

[bridgekeeper]

👋 Welcome back herrick! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@andyherrick The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (247bc2c)
• 01: Full - Incremental (3d83b99)
• 00: Full (196a9de)

[alexeysemenyukoracle]

How about executeLauncher() method? It will not clear the environment.
I'd adjust getVerifier() method instead and store flag to clear launcher environment in JPackageCommand instanceinstead.
Something like this:

public JPackageCommand JPackageCommand.setClearLauncherEnv(boolean value) {
  clearLauncherEnv = value;
  return this;
}

boolean JPackageCommand.getClearLauncherEnv() {
  return clearLauncherEnv;
}

AppOuputVerifier.setClearLauncherEnv(boolean value) {
  clearLauncherEnv = value;
}

AppOuputVerifier HelloApp.getVerifier(JPackageCommand cmd, String... args) {
  AppOuputVerifier reply = ...;
  reply.setClearLauncherEnv(cmd.getClearLauncherEnv());
  return reply;
}

[azuev-java]

Looks good.

[openjdk]

@andyherrick This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254920: Application launched with jpackage produced .exe crashes JVM

Reviewed-by: asemenyuk, almatvee, kizune

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• e66fd6f: 8255756: Disabling logging does unnecessary work
• 140c162: 8255894: Remove unused StubRoutines::_zero_aligned_words
• fc894ab: 8255955: Shenandoah: Only STW GC should process concurrent roots at pauses
• d6f0940: 8255913: Decrease number of iterations in TestMaxCachedBufferSize

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[andyherrick]

/integrate

[openjdk]

@andyherrick Since your change was applied there have been 8 commits pushed to the master branch:

• 5dfb42f: 8255563: Missing NULL checks after JDK-8233624
• e730e8b: 8241806: The sun/awt/shell/FileSystemViewMemoryLeak.java is unstable
• 57b98fa: 8255965: LogCompilation: add sort by nmethod code size
• e42c134: 8255706: The JDWP debug agent unecessarily checks for JVMTI_ERROR_INTERRUPT after calling RawMonitorEnter
• e66fd6f: 8255756: Disabling logging does unnecessary work
• 140c162: 8255894: Remove unused StubRoutines::_zero_aligned_words
• fc894ab: 8255955: Shenandoah: Only STW GC should process concurrent roots at pauses
• d6f0940: 8255913: Decrease number of iterations in TestMaxCachedBufferSize

Your commit was automatically rebased without conflicts.

Pushed as commit 952abea.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.