Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8213126: java/awt/Window/MainKeyWindow/TestMainKeyWindow.java time-out on mac10.13 #941

Closed
wants to merge 3 commits into from

Conversation

@mrserb
Copy link
Member

@mrserb mrserb commented Oct 29, 2020

Initially, this bug was filed because the test was run via jtreg without passing '-nativepath' option(the make file pass this option automatically). So we could just de-problem list the test, but on the macOS Catalina the "System Preferences.app" was moved so the test cannot run it. As a fix, I suggest running the java app via a separate process instead of "System Preferences.app".

The test still fails before JDK-8194327, and passed after.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8213126: java/awt/Window/MainKeyWindow/TestMainKeyWindow.java time-out on mac10.13

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/941/head:pull/941
$ git checkout pull/941

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 29, 2020

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 29, 2020

@mrserb The following label will be automatically applied to this pull request:

  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the awt label Oct 29, 2020
@mrserb mrserb marked this pull request as ready for review Oct 29, 2020
@openjdk openjdk bot added the rfr label Oct 29, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 29, 2020

Webrevs

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 27, 2020

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@mrserb
Copy link
Member Author

@mrserb mrserb commented Nov 30, 2020

Any volunteers for a review?

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 28, 2020

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@mrserb
Copy link
Member Author

@mrserb mrserb commented Dec 31, 2020

Any volunteers for a review?

@@ -29,6 +29,7 @@
* @bug 8194327
* @summary [macosx] AWT windows have incorrect main/key window behaviors
* @author Alan Snyder
Copy link
Contributor

@prsadhuk prsadhuk Jan 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we need to remove @author tag

Copy link
Member Author

@mrserb mrserb Jan 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left it to make credit an external contributor

frame.toFront();
Thread.sleep(20_000);
System.exit(0);
return;
Copy link
Contributor

@prsadhuk prsadhuk Jan 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please explain the reasoning for this snippet where we exit the test. What extra args can be passed? I guess it will exit the whole jtreg vm process cancelling all other tests that are to be run later if we call System.exit?!! or is this only for standalone execution?

Copy link
Member Author

@mrserb mrserb Jan 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part of the code is executed by the test itself see this code above

            ProcessBuilder pb = ProcessTools.createJavaProcessBuilder(
                    TestMainKeyWindow.class.getSimpleName(), "mark");
            return ProcessTools.startProcess("Other frame", pb);

@openjdk
Copy link

@openjdk openjdk bot commented Jan 6, 2021

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8213126: java/awt/Window/MainKeyWindow/TestMainKeyWindow.java time-out on mac10.13

Reviewed-by: psadhukhan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 6, 2021
@mrserb
Copy link
Member Author

@mrserb mrserb commented Jan 7, 2021

/integrate

@openjdk openjdk bot closed this Jan 7, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 7, 2021

@mrserb Since your change was applied there have been 7 commits pushed to the master branch:

  • 8530ef0: 8259375: JvmtiExport::jni_Get/SetField_probe calls do not need ResetNoHandleMark
  • f91f92d: 8259317: Remove JVM option BreakAtWarning
  • 3f9f86f: 8258484: AIX build fails in Harfbuzz with XLC 16.01.0000.0006
  • 1c33847: 8259067: bootclasspath append takes out object lock
  • 0e6de4e: 8259339: AllocateUninitializedArray C2 intrinsic fails with void.class input
  • 81c0624: 8259354: Fix race condition in AbstractEventStream.nextThreadName
  • 227f99d: 8233555: [TESTBUG] JRadioButton tests failing on MacoS

Your commit was automatically rebased without conflicts.

Pushed as commit 2e99e28.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the JDK-8213126 branch Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants