Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8289853: Update HarfBuzz to 4.4.1 #9420

Closed
wants to merge 2 commits into from

Conversation

prrace
Copy link
Contributor

@prrace prrace commented Jul 7, 2022

This upgrades the JDK's version of harfbuzz to 4.4.1. The current version is 2.8.0
Builds on all platforms. Testing looks good.
I've added an UPDATING.txt file with tips on the steps involved in these upgrades.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9420/head:pull/9420
$ git checkout pull/9420

Update a local copy of the PR:
$ git checkout pull/9420
$ git pull https://git.openjdk.org/jdk pull/9420/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9420

View PR using the GUI difftool:
$ git pr show -t 9420

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9420.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 7, 2022

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8289853 8289853: Update HarfBuzz to 4.4.1 Jul 7, 2022
@openjdk
Copy link

openjdk bot commented Jul 7, 2022

@prrace The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Jul 7, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 8, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 8, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 11, 2022

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289853: Update HarfBuzz to 4.4.1

Reviewed-by: serb, azvegint

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 87 new commits pushed to the master branch:

  • 21db9a5: 8290065: [JVMCI] only check HotSpotCompiledCode stream is empty if installation succeeds
  • c79baaa: Merge
  • cb6e9cb: 8290004: [PPC64] JfrGetCallTrace: assert(_pc != nullptr) failed: must have PC
  • 0494291: 8289692: JFR: Thread checkpoint no longer enforce mutual exclusion post Loom integration
  • 25f4b04: 8289894: A NullPointerException thrown from guard expression
  • b542bcb: 8289729: G1: Incorrect verification logic in G1ConcurrentMark::clear_next_bitmap
  • c86c51c: 8282071: Update java.xml module-info
  • 9981c85: 8290033: ProblemList serviceability/jvmti/GetLocalVariable/GetLocalWithoutSuspendTest.java on windows-x64 in -Xcomp mode
  • c142fbb: 8289697: buffer overflow in MTLVertexCache.m: MTLVertexCache_AddGlyphQuad
  • eeaf0bb: 8289872: wrong wording in @param doc for HashMap.newHashMap et. al.
  • ... and 77 more: https://git.openjdk.org/jdk/compare/35387d5cb6aa9e59d62b8e1b137b53ec88521310...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 11, 2022
@prrace
Copy link
Contributor Author

prrace commented Jul 11, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jul 11, 2022

Going to push as commit f42dab8.
Since your change was applied there have been 87 commits pushed to the master branch:

  • 21db9a5: 8290065: [JVMCI] only check HotSpotCompiledCode stream is empty if installation succeeds
  • c79baaa: Merge
  • cb6e9cb: 8290004: [PPC64] JfrGetCallTrace: assert(_pc != nullptr) failed: must have PC
  • 0494291: 8289692: JFR: Thread checkpoint no longer enforce mutual exclusion post Loom integration
  • 25f4b04: 8289894: A NullPointerException thrown from guard expression
  • b542bcb: 8289729: G1: Incorrect verification logic in G1ConcurrentMark::clear_next_bitmap
  • c86c51c: 8282071: Update java.xml module-info
  • 9981c85: 8290033: ProblemList serviceability/jvmti/GetLocalVariable/GetLocalWithoutSuspendTest.java on windows-x64 in -Xcomp mode
  • c142fbb: 8289697: buffer overflow in MTLVertexCache.m: MTLVertexCache_AddGlyphQuad
  • eeaf0bb: 8289872: wrong wording in @param doc for HashMap.newHashMap et. al.
  • ... and 77 more: https://git.openjdk.org/jdk/compare/35387d5cb6aa9e59d62b8e1b137b53ec88521310...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 11, 2022
@openjdk openjdk bot closed this Jul 11, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 11, 2022
@openjdk
Copy link

openjdk bot commented Jul 11, 2022

@prrace Pushed as commit f42dab8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants