8274235: -Xshare:dump should not call vm_direct_exit

[calvinccheung]

Just changing the vm_direct_exit calls during CDS dump time to os::_exit.

Passed tiers 1 and 2 tests on Oracle supported platforms.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8274235: -Xshare:dump should not call vm_direct_exit

Reviewers

• Ioi Lam (@iklam - Reviewer)
• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9421/head:pull/9421
$ git checkout pull/9421

Update a local copy of the PR:
$ git checkout pull/9421
$ git pull https://git.openjdk.org/jdk pull/9421/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9421

View PR using the GUI difftool:
$ git pr show -t 9421

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9421.diff

[calvinccheung]

/label add hotspot-runtime

[bridgekeeper]

👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@calvinccheung
The hotspot-runtime label was successfully added.

[mlbridge]

Webrevs

• 00: Full (5751687d)

[iklam]

LGTM

[openjdk]

@calvinccheung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274235: -Xshare:dump should not call vm_direct_exit

Reviewed-by: iklam, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 31 new commits pushed to the master branch:

• 87aa3ce: 8289274: Cleanup unnecessary null comparison before instanceof check in security modules
• 81ee7d2: 8289186: Support predicated vector load/store operations over X86 AVX2 targets.
• 3c08e6b: 8289780: Avoid formatting stub names when Forte is not enabled
• 54b4576: 8288699: cleanup HTML tree in HtmlDocletWriter.commentTagsToContent
• 6aaf141: 8289984: Files:isDirectory and isRegularFile methods not throwing SecurityException
• 1877533: 6522064: Aliases from Microsoft CryptoAPI has bad character encoding
• 9c86c82: 8282714: synthetic arguments are being added to the constructors of static local classes
• e779585: 8271707: migrate tests to use jdk.test.whitebox.WhiteBox
• d852e99: 8289697: buffer overflow in MTLVertexCache.m: MTLVertexCache_AddGlyphQuad
• a13af65: 8282322: AArch64: Provide a means to eliminate all STREX family of instructions
• ... and 21 more: https://git.openjdk.org/jdk/compare/a694e9e34d1e4388df200d11b168ca5265cea4ac...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dholmes-ora]

LGTM2.

Thanks.

[calvinccheung]

Thanks @iklam and @dholmes-ora.

/integrate

[openjdk]

Going to push as commit c33fa55.
Since your change was applied there have been 42 commits pushed to the master branch:

• 59980ac: 8288309: Rename the "testTagInheritence" directory
• fc01666: 8290002: (se) AssertionError in SelectorImpl.implCloseSelector
• 95c8022: 8290046: NMT: Remove unused MallocSiteTable::reset()
• 0c37008: 8275662: remove test/lib/sun/hotspot
• 46251bc: 8224267: JOptionPane message string with 5000+ newlines produces StackOverflowError
• bba6be7: 8269674: Improve testing of parenthesized patterns
• 2579373: 8280472: Don't mix legacy logging with UL
• 0225eb4: 8290018: Remove dead declarations in G1BlockOffsetTablePart
• e259820: 8290019: Refactor HeapRegion::oops_on_memregion_iterate()
• 4ab77ac: 8290017: Directly call HeapRegion::block_start in G1CMObjArrayProcessor::process_slice
• ... and 32 more: https://git.openjdk.org/jdk/compare/a694e9e34d1e4388df200d11b168ca5265cea4ac...master

Your commit was automatically rebased without conflicts.

[openjdk]

@calvinccheung Pushed as commit c33fa55.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.