8290017: Directly call HeapRegion::block_start in G1CMObjArrayProcessor::process_slice

[tschatzl]

Hi all,

please review this small change to have G1CMObjArrayProcessor::process_slice call HeapRegion::block directly instead of indirectly via G1CollectedHeap. This saves a check and an indirection (but generally isn't perf sensitive anyway, but still).

Testing: tier1-3

Thanks,
Thomas

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8290017: Directly call HeapRegion::block_start in G1CMObjArrayProcessor::process_slice

Reviewers

• Albert Mingkun Yang (@albertnetymk - Reviewer)
• Ivan Walulya (@walulyai - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9428/head:pull/9428
$ git checkout pull/9428

Update a local copy of the PR:
$ git checkout pull/9428
$ git pull https://git.openjdk.org/jdk pull/9428/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9428

View PR using the GUI difftool:
$ git pr show -t 9428

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9428.diff

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (5e833784)

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290017: Directly call HeapRegion::block_start in G1CMObjArrayProcessor::process_slice

Reviewed-by: ayang, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

• e9d9cc6: 8290027: Move inline functions from vm_version_x86.hpp to cpp
• 87aa3ce: 8289274: Cleanup unnecessary null comparison before instanceof check in security modules
• 81ee7d2: 8289186: Support predicated vector load/store operations over X86 AVX2 targets.
• 3c08e6b: 8289780: Avoid formatting stub names when Forte is not enabled
• 54b4576: 8288699: cleanup HTML tree in HtmlDocletWriter.commentTagsToContent
• 6aaf141: 8289984: Files:isDirectory and isRegularFile methods not throwing SecurityException
• 1877533: 6522064: Aliases from Microsoft CryptoAPI has bad character encoding
• 9c86c82: 8282714: synthetic arguments are being added to the constructors of static local classes
• e779585: 8271707: migrate tests to use jdk.test.whitebox.WhiteBox

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tschatzl]

Thanks @albertnetymk @walulyai for your reviews
/integrate

[openjdk]

Going to push as commit 4ab77ac.
Since your change was applied there have been 9 commits pushed to the master branch:

• e9d9cc6: 8290027: Move inline functions from vm_version_x86.hpp to cpp
• 87aa3ce: 8289274: Cleanup unnecessary null comparison before instanceof check in security modules
• 81ee7d2: 8289186: Support predicated vector load/store operations over X86 AVX2 targets.
• 3c08e6b: 8289780: Avoid formatting stub names when Forte is not enabled
• 54b4576: 8288699: cleanup HTML tree in HtmlDocletWriter.commentTagsToContent
• 6aaf141: 8289984: Files:isDirectory and isRegularFile methods not throwing SecurityException
• 1877533: 6522064: Aliases from Microsoft CryptoAPI has bad character encoding
• 9c86c82: 8282714: synthetic arguments are being added to the constructors of static local classes
• e779585: 8271707: migrate tests to use jdk.test.whitebox.WhiteBox

Your commit was automatically rebased without conflicts.

[openjdk]

@tschatzl Pushed as commit 4ab77ac.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.