Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8290019: Refactor HeapRegion::oops_on_memregion_iterate() #9430

Conversation

tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Jul 8, 2022

Hi all,

please review this potential refactoring for HeapRegion::oops_on_memregion_iterate(); it's a bit subjective imo if the code is better now, so please feel free to say so and I'll retract.

Testing: tier1-3

Thanks,
Thomas


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8290019: Refactor HeapRegion::oops_on_memregion_iterate()

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9430/head:pull/9430
$ git checkout pull/9430

Update a local copy of the PR:
$ git checkout pull/9430
$ git pull https://git.openjdk.org/jdk pull/9430/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9430

View PR using the GUI difftool:
$ git pr show -t 9430

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9430.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 8, 2022

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8290019 8290019: Refactor HeapRegion::oops_on_memregion_iterate() Jul 8, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 8, 2022
@openjdk
Copy link

openjdk bot commented Jul 8, 2022

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Jul 8, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 8, 2022

Webrevs

@@ -402,31 +402,19 @@ HeapWord* HeapRegion::do_oops_on_memregion_in_humongous(MemRegion mr,
}

template <class Closure>
inline HeapWord* HeapRegion::oops_on_memregion_iterate_in_unparsable(MemRegion mr, HeapWord* const pb, Closure* cl) {
// Cache the boundaries of the area to scan in some locals.
inline HeapWord* HeapRegion::oops_on_memregion_iterate_in_unparsable(MemRegion mr, HeapWord* block_start, Closure* cl) {
HeapWord* const start = mr.start();
// Only scan until parsable_bottom.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment can be dropped now.

@openjdk
Copy link

openjdk bot commented Jul 10, 2022

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290019: Refactor HeapRegion::oops_on_memregion_iterate()

Reviewed-by: ayang, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 4ab77ac: 8290017: Directly call HeapRegion::block_start in G1CMObjArrayProcessor::process_slice
  • e9d9cc6: 8290027: Move inline functions from vm_version_x86.hpp to cpp
  • 87aa3ce: 8289274: Cleanup unnecessary null comparison before instanceof check in security modules
  • 81ee7d2: 8289186: Support predicated vector load/store operations over X86 AVX2 targets.
  • 3c08e6b: 8289780: Avoid formatting stub names when Forte is not enabled
  • 54b4576: 8288699: cleanup HTML tree in HtmlDocletWriter.commentTagsToContent
  • 6aaf141: 8289984: Files:isDirectory and isRegularFile methods not throwing SecurityException
  • 1877533: 6522064: Aliases from Microsoft CryptoAPI has bad character encoding
  • 9c86c82: 8282714: synthetic arguments are being added to the constructors of static local classes
  • e779585: 8271707: migrate tests to use jdk.test.whitebox.WhiteBox

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 10, 2022
@tschatzl
Copy link
Contributor Author

Thanks @walulyai @albertnetymk for your reviews

/integrate

@openjdk
Copy link

openjdk bot commented Jul 11, 2022

Going to push as commit e259820.
Since your change was applied there have been 10 commits pushed to the master branch:

  • 4ab77ac: 8290017: Directly call HeapRegion::block_start in G1CMObjArrayProcessor::process_slice
  • e9d9cc6: 8290027: Move inline functions from vm_version_x86.hpp to cpp
  • 87aa3ce: 8289274: Cleanup unnecessary null comparison before instanceof check in security modules
  • 81ee7d2: 8289186: Support predicated vector load/store operations over X86 AVX2 targets.
  • 3c08e6b: 8289780: Avoid formatting stub names when Forte is not enabled
  • 54b4576: 8288699: cleanup HTML tree in HtmlDocletWriter.commentTagsToContent
  • 6aaf141: 8289984: Files:isDirectory and isRegularFile methods not throwing SecurityException
  • 1877533: 6522064: Aliases from Microsoft CryptoAPI has bad character encoding
  • 9c86c82: 8282714: synthetic arguments are being added to the constructors of static local classes
  • e779585: 8271707: migrate tests to use jdk.test.whitebox.WhiteBox

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 11, 2022
@openjdk openjdk bot closed this Jul 11, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 11, 2022
@openjdk
Copy link

openjdk bot commented Jul 11, 2022

@tschatzl Pushed as commit e259820.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tschatzl tschatzl deleted the submit/8290019-refactor-mem-iterate-careful branch July 29, 2022 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
3 participants