8290027: Move inline functions from vm_version_x86.hpp to cpp

[iklam]

There are several large inline functions in vm_version_x86.hpp that are used only by vm_version_x86.cpp. E.g., feature_flags()

These should be moved to vm_version_x86.cpp to improve C++ build speed.

I manually diff'ed the lines that were moved between the two files. They were identical except for whitespaces.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8290027: Move inline functions from vm_version_x86.hpp to cpp

Reviewers

• Kim Barrett (@kimbarrett - Reviewer) ⚠️ Review applies to 9ff42ede
• David Holmes (@dholmes-ora - Reviewer) ⚠️ Review applies to 9ff42ede

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9431/head:pull/9431
$ git checkout pull/9431

Update a local copy of the PR:
$ git checkout pull/9431
$ git pull https://git.openjdk.org/jdk pull/9431/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9431

View PR using the GUI difftool:
$ git pr show -t 9431

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9431.diff

[bridgekeeper]

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@iklam The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (9b38dce8)
• 00: Full (9ff42ede)

[kimbarrett]

Looks good.

[openjdk]

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290027: Move inline functions from vm_version_x86.hpp to cpp

Reviewed-by: kbarrett, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dholmes-ora]

Seems fine. thanks.

[iklam]

Thanks to @kimbarrett and @dholmes-ora for the review.
/integrate

[openjdk]

Going to push as commit e9d9cc6.

[openjdk]

@iklam Pushed as commit e9d9cc6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.