8255617: Zero: purge the remaining bytecode interpreter profiling support #944
@shipilev This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
After integration, the commit message for the final commit will be:
At the time when this comment was updated there had been 28 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
➡️ To integrate this PR with the above commit message to the
It is my understanding that Zero had basically stepped back to be the "pure" interpreter without any support for compilers, and thus becoming the most portable thing, for example for architectures that have no arch-specific code implemented whatsoever. When one needs an interpreter that hooks into C1/C2, they have to go to template interpreter and start implementing arch-specific stuff. So, porting is basically: a) get Zero working; b) get template interpreter working; c) get C1 working; d) get C2 working. On each of these steps you have something that works, with every step much harder to get it right, but better for performance.
So in this sense, having compiler hooks (like this interpreter profile support) penalizes Zero execution for nothing. If we continue it further, I'd say we can also purge deopt support from Zero too.
Need more thoughts about this, so:
IIRC the original idea of Zero's compiler support was for shark (via LLVM). That got removed with JDK-8171853. It seems fine to remove profiling support too. So what @shipilev said above makes sense to me. Zero is mostly a porter's tool. Keeping it as simple as possible seems the better approach. +1
All tests for Zero VM passed in our CI/CD.
@shipilev Since your change was applied there have been 29 commits pushed to the
Your commit was automatically rebased without conflicts.
Pushed as commit a5d8a9c.
💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.
…port Reviewed-by: coleenp, sgehwolf, jiefu