8290023: Remove use of IgnoreUnrecognizedVMOptions in gc tests

[tschatzl]

Hi all,

can I have reviews for removal of the use of -XX:+IgnoreUnrecognizedVMOptions for gc tests?

As per JDK-8228493 use of that option has drawbacks wrt to test reliability, so trying to remove them by

• duplicating @test blocks (mostly sme Shenandoah tests as I could not find a good way for them)
• adding additional @requires
• removing it in tests where it is not actually required

Testing: gha, running tests

Thanks,
Thomas

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8290023: Remove use of IgnoreUnrecognizedVMOptions in gc tests

Reviewers

• Albert Mingkun Yang (@albertnetymk - Reviewer) ⚠️ Review applies to 9848697e
• Leo Korinth (@lkorinth - Reviewer) ⚠️ Review applies to 279b99d9
• Kim Barrett (@kimbarrett - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9443/head:pull/9443
$ git checkout pull/9443

Update a local copy of the PR:
$ git checkout pull/9443
$ git pull https://git.openjdk.org/jdk pull/9443/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9443

View PR using the GUI difftool:
$ git pr show -t 9443

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9443.diff

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl The following labels will be automatically applied to this pull request:

• hotspot-gc
• shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 04: Full - Incremental (f94c5b5e)
• 03: Full - Incremental (4c5d78f6)
• 02: Full - Incremental (1b530193)
• 01: Full - Incremental (279b99d9)
• 00: Full (9848697e)

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290023: Remove use of IgnoreUnrecognizedVMOptions in gc tests

Reviewed-by: ayang, lkorinth, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 47 new commits pushed to the master branch:

• 6e18883: 8290162: Reset recursion counter missed in fix of JDK-8224267
• 31f7fc0: 8283082: sun.security.x509.X509CertImpl.delete("x509.info.validity") nulls out info field
• d9ca438: Merge
• 3164c98: 8289148: j.l.foreign.VaList::nextVarg call could throw IndexOutOfBoundsException or even crash the VM
• c3806b9: 8289709: fatal error: stuck in JvmtiVTMSTransitionDisabler::disable_VTMS_transitions
• 39715f3: 8287902: UnreadableRB case in MissingResourceCauseTest is not working reliably on Windows
• 62fbc3f: 8287379: Using @inheritdoc in an inapplicable context shouldn't crash javadoc
• fed3af8: 8287809: Revisit implementation of memory session
• e8568b8: 8290020: Deadlock in leakprofiler::emit_events during shutdown
• 7f0e9bd: 8289745: JfrStructCopyFailed uses heap words instead of bytes for object sizes
• ... and 37 more: https://git.openjdk.org/jdk/compare/87aa3ce03e5e294b35cf2cab3cbba0d1964bbbff...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[lkorinth]

I have looked through the change, and it looks mostly good to me. TestEagerReclaimHumongousRegionsClearMarkBits after the change only runs in debug builds, is that made on purpose?

[tschatzl]

I have looked through the change, and it looks mostly good to me. TestEagerReclaimHumongousRegionsClearMarkBits after the change only runs in debug builds, is that made on purpose?

TestEagerReclaimHumongousRegionsClearMarkBits is not going to crash due to bitmap verification error in product mode because that verification is debug mode only. At most it could crash due to other reasons, but I do not think it is worth running the test for random suspicion that something might be wrong that other tests would highly likely also pick up.

[lkorinth]

Looks good, and thanks for removing -XX:+IgnoreUnrecognizedVMOptions from our test cases.

[lkorinth]

Looks good.

[kimbarrett]

Looks good.

[kimbarrett]

Drat! I meant to check for that and then forgot. Looks good.

[tschatzl]

Thanks @kimbarrett @albertnetymk @lkorinth for your reviews.

/integrate

[openjdk]

Going to push as commit 2583feb.
Since your change was applied there have been 50 commits pushed to the master branch:

• 44fb92e: 8290197: test/jdk/java/nio/file/Files/probeContentType/Basic.java fails on some systems for the ".rar" extension
• f528124: 8289284: jdk.tracePinnedThreads output confusing when pinned due to native frame
• 572c14e: 8288624: Cleanup CommentHelper.getText0
• 6e18883: 8290162: Reset recursion counter missed in fix of JDK-8224267
• 31f7fc0: 8283082: sun.security.x509.X509CertImpl.delete("x509.info.validity") nulls out info field
• d9ca438: Merge
• 3164c98: 8289148: j.l.foreign.VaList::nextVarg call could throw IndexOutOfBoundsException or even crash the VM
• c3806b9: 8289709: fatal error: stuck in JvmtiVTMSTransitionDisabler::disable_VTMS_transitions
• 39715f3: 8287902: UnreadableRB case in MissingResourceCauseTest is not working reliably on Windows
• 62fbc3f: 8287379: Using @inheritdoc in an inapplicable context shouldn't crash javadoc
• ... and 40 more: https://git.openjdk.org/jdk/compare/87aa3ce03e5e294b35cf2cab3cbba0d1964bbbff...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tschatzl Pushed as commit 2583feb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.