New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8289562: Change bugs.java.com and bugreport.java.com URL's to https #9445
Conversation
Hi @jcherian-se, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user jcherian-se" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
To avoid this situation, create a new branch for your changes and reset the
Then proceed to create a new pull request with |
@jcherian-se The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
/covered |
Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated! |
Webrevs
|
It is a trivial change and looks good to me (I am not a reviewer). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me. However the langtools / javadoc folks seem like they should be primary reviewers since it is mostly messages from the tools.
@jcherian-se This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@prrace, @jonathan-gibbons, @naotoj, @irisclark) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jdk.compiler
and jdk.javadoc
changes look OK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those .properties
bundle changes look good.
/integrate |
@jcherian-se |
@fmatte1 Only the author (@jcherian-se) is allowed to issue the |
/contributor joe.cherian@oracle.com |
@jcherian-se Syntax:
User names can only be used for users in the census associated with this repository. For other contributors you need to supply the full name and email address. |
/contributor add Joe Cherian joe.cherian@oracle.com |
@jcherian-se |
/sponsor |
Going to push as commit 1f484da.
Your commit was automatically rebased without conflicts. |
@fmatte1 @jcherian-se Pushed as commit 1f484da. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Progress
Issue
Reviewers
Contributors
<joe.cherian@oracle.com>
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9445/head:pull/9445
$ git checkout pull/9445
Update a local copy of the PR:
$ git checkout pull/9445
$ git pull https://git.openjdk.org/jdk pull/9445/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 9445
View PR using the GUI difftool:
$ git pr show -t 9445
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9445.diff