Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8289562: Change bugs.java.com and bugreport.java.com URL's to https #9445

Closed
wants to merge 3 commits into from

Conversation

jcherian-se
Copy link
Contributor

@jcherian-se jcherian-se commented Jul 11, 2022


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8289562: Change bugs.java.com and bugreport.java.com URL's to https

Reviewers

Contributors

  • Joe Cherian <joe.cherian@oracle.com>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9445/head:pull/9445
$ git checkout pull/9445

Update a local copy of the PR:
$ git checkout pull/9445
$ git pull https://git.openjdk.org/jdk pull/9445/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9445

View PR using the GUI difftool:
$ git pr show -t 9445

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9445.diff

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Jul 11, 2022
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 11, 2022

Hi @jcherian-se, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user jcherian-se" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Jul 11, 2022

⚠️ @jcherian-se a branch with the same name as the source branch for this pull request (master) is present in the target repository. If you eventually integrate this pull request then the branch master in your personal fork will diverge once you sync your personal fork with the upstream repository.

To avoid this situation, create a new branch for your changes and reset the master branch. You can do this by running the following commands in a local repository for your personal fork. Note: you do not have to name the new branch NEW-BRANCH-NAME.

$ git checkout -b NEW-BRANCH-NAME
$ git branch -f master 4ab77ac60df78eedb16ebe142a51f703165e808d
$ git push -f origin master

Then proceed to create a new pull request with NEW-BRANCH-NAME as the source branch and close this one.

@openjdk
Copy link

openjdk bot commented Jul 11, 2022

@jcherian-se The following labels will be automatically applied to this pull request:

  • client
  • compiler
  • core-libs
  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added javadoc javadoc-dev@openjdk.org client client-libs-dev@openjdk.org core-libs core-libs-dev@openjdk.org compiler compiler-dev@openjdk.org labels Jul 11, 2022
@jcherian-se
Copy link
Contributor Author

/covered

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Jul 11, 2022
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 11, 2022

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@bridgekeeper bridgekeeper bot removed oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status labels Aug 1, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 1, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 1, 2022

Webrevs

@fmatte1
Copy link

fmatte1 commented Aug 1, 2022

It is a trivial change and looks good to me (I am not a reviewer).

Copy link
Contributor

@prrace prrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. However the langtools / javadoc folks seem like they should be primary reviewers since it is mostly messages from the tools.

@openjdk
Copy link

openjdk bot commented Aug 1, 2022

@jcherian-se This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289562: Change bugs.java.com and bugreport.java.com URL's to https

Co-authored-by: Joe Cherian <joe.cherian@oracle.com>
Reviewed-by: prr, jjg, naoto, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 63a126a: 8292607: Remove unused dirty and dirty_card_range_after_reset in CardTable
  • 7d18ebd: 8292606: G1 and Epsilon header cleanup for JDK-8282729

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@prrace, @jonathan-gibbons, @naotoj, @irisclark) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 1, 2022
Copy link
Contributor

@jonathan-gibbons jonathan-gibbons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jdk.compiler and jdk.javadoc changes look OK

Copy link
Member

@naotoj naotoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those .properties bundle changes look good.

@jcherian-se
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 19, 2022
@openjdk
Copy link

openjdk bot commented Aug 19, 2022

@jcherian-se
Your change (at version 07b7be0) is now ready to be sponsored by a Committer.

@openjdk
Copy link

openjdk bot commented Aug 19, 2022

@fmatte1 Only the author (@jcherian-se) is allowed to issue the contributor command.

@jcherian-se
Copy link
Contributor Author

/contributor joe.cherian@oracle.com

@openjdk
Copy link

openjdk bot commented Aug 19, 2022

@jcherian-se Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

  • /contributor add @openjdk-bot
  • /contributor add duke
  • /contributor add J. Duke <duke@openjdk.org>

User names can only be used for users in the census associated with this repository. For other contributors you need to supply the full name and email address.

@jcherian-se
Copy link
Contributor Author

jcherian-se commented Aug 19, 2022

/contributor add Joe Cherian joe.cherian@oracle.com

@openjdk
Copy link

openjdk bot commented Aug 19, 2022

@jcherian-se
Contributor Joe Cherian <joe.cherian@oracle.com> successfully added.

@fmatte1
Copy link

fmatte1 commented Aug 19, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 19, 2022

Going to push as commit 1f484da.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 63a126a: 8292607: Remove unused dirty and dirty_card_range_after_reset in CardTable
  • 7d18ebd: 8292606: G1 and Epsilon header cleanup for JDK-8282729

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 19, 2022
@openjdk openjdk bot closed this Aug 19, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 19, 2022
@openjdk
Copy link

openjdk bot commented Aug 19, 2022

@fmatte1 @jcherian-se Pushed as commit 1f484da.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org compiler compiler-dev@openjdk.org core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated javadoc javadoc-dev@openjdk.org
6 participants