8290133: JFR: Remove unused methods in Bits.java

[egahlin]

Could I have a review of PR that removes some unused methods.

Testing: jdk/jdk/jfr

Thanks
Erik

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8290133: JFR: Remove unused methods in Bits.java

Reviewers

• Markus Grönlund (@mgronlun - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9457/head:pull/9457
$ git checkout pull/9457

Update a local copy of the PR:
$ git checkout pull/9457
$ git pull https://git.openjdk.org/jdk pull/9457/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9457

View PR using the GUI difftool:
$ git pr show -t 9457

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9457.diff

[bridgekeeper]

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@egahlin The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (66fa48a0)

[openjdk]

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290133: JFR: Remove unused methods in Bits.java

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

• 393dc7a: 8290082: [PPC64] ZGC C2 load barrier stub needs to preserve vector registers
• e5491a2: 8289910: unify os::message_box across posix platforms
• 04c47da: 8289768: Clean up unused code
• 3b9059a: 8290083: ResponseBodyBeforeError: AssertionError or SSLException: Unsupported or unrecognized SSL message
• f42dab8: 8289853: Update HarfBuzz to 4.4.1
• 21db9a5: 8290065: [JVMCI] only check HotSpotCompiledCode stream is empty if installation succeeds
• c79baaa: Merge
• cb6e9cb: 8290004: [PPC64] JfrGetCallTrace: assert(_pc != nullptr) failed: must have PC
• 0494291: 8289692: JFR: Thread checkpoint no longer enforce mutual exclusion post Loom integration
• 25f4b04: 8289894: A NullPointerException thrown from guard expression
• ... and 14 more: https://git.openjdk.org/jdk/compare/fc01666a5824d55b2549c81c0c3602aafdec693c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[egahlin]

/integrate

[openjdk]

Going to push as commit 0e90697.
Since your change was applied there have been 25 commits pushed to the master branch:

• ea12615: 8288984: Simplification in java.lang.Runtime::exit
• 393dc7a: 8290082: [PPC64] ZGC C2 load barrier stub needs to preserve vector registers
• e5491a2: 8289910: unify os::message_box across posix platforms
• 04c47da: 8289768: Clean up unused code
• 3b9059a: 8290083: ResponseBodyBeforeError: AssertionError or SSLException: Unsupported or unrecognized SSL message
• f42dab8: 8289853: Update HarfBuzz to 4.4.1
• 21db9a5: 8290065: [JVMCI] only check HotSpotCompiledCode stream is empty if installation succeeds
• c79baaa: Merge
• cb6e9cb: 8290004: [PPC64] JfrGetCallTrace: assert(_pc != nullptr) failed: must have PC
• 0494291: 8289692: JFR: Thread checkpoint no longer enforce mutual exclusion post Loom integration
• ... and 15 more: https://git.openjdk.org/jdk/compare/fc01666a5824d55b2549c81c0c3602aafdec693c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@egahlin Pushed as commit 0e90697.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.