Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8255612: Explicitly disable dtrace for Oracle OpenJDK Linux builds #946

Closed
wants to merge 1 commit into from

Conversation

erikj79
Copy link
Member

@erikj79 erikj79 commented Oct 29, 2020

The OpenJDK build on Linux will determine if the JVM feature "dtrace" should be enabled based on the availability of dtrace on the build host. For Oracle produced OpenJDK builds, we implicitly had this disabled because our build environment didn't have it installed. Rather than having to trust the build host to not have dtrace installed, we would like to make this setting explicit. We don't want to change the default behavior of OpenJDK, so we are adding this configure flag to the jib-profiles.js configuration where appropriate, so it only affects Oracle produced builds.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8255612: Explicitly disable dtrace for Oracle OpenJDK Linux builds

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/946/head:pull/946
$ git checkout pull/946

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 29, 2020

👋 Welcome back erikj! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 29, 2020
@openjdk
Copy link

openjdk bot commented Oct 29, 2020

@erikj79 The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Oct 29, 2020
@mlbridge
Copy link

mlbridge bot commented Oct 29, 2020

Webrevs

vidmik
vidmik approved these changes Oct 29, 2020
@openjdk
Copy link

openjdk bot commented Oct 29, 2020

@erikj79 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255612: Explicitly disable dtrace for Oracle OpenJDK Linux builds

Reviewed-by: mikael

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

  • a756320: 8255536: Remove the directsign property and option
  • f77a658: 8153005: Upgrade the default PKCS12 encryption/MAC algorithms
  • 8a065ef: 8255005: Fix indentation levels in classFileParser.cpp
  • e48016b: 8255565: [Vector API] Add missing format strings for extract instructs in x86.ad
  • 2c7fc85: 8254972: Fix pretouch chunk calculations
  • d128191: 8253473: Javadoc clean up in HttpHandler, HttpPrincipal, HttpContext, and HttpsConfigurator
  • 379ba80: 8255595: delay_to_keep_mmu passes wrong arguments to Monitor wait
  • 1a89d68: 8255285: Move JVMFlag origins into a new enum JVMFlagOrigin
  • 56eb5f5: 8255466: C2 crashes at ciObject::get_oop() const+0x0
  • 5782a2a: 8254975: lambda proxy fails to access a protected member inherited from a split package
  • ... and 6 more: https://git.openjdk.java.net/jdk/compare/faf23de54d81d70044d429f1081e10f2b6474e78...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 29, 2020
@erikj79
Copy link
Member Author

erikj79 commented Oct 30, 2020

/integrate

@openjdk openjdk bot closed this Oct 30, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 30, 2020
@openjdk
Copy link

openjdk bot commented Oct 30, 2020

@erikj79 Since your change was applied there have been 16 commits pushed to the master branch:

  • a756320: 8255536: Remove the directsign property and option
  • f77a658: 8153005: Upgrade the default PKCS12 encryption/MAC algorithms
  • 8a065ef: 8255005: Fix indentation levels in classFileParser.cpp
  • e48016b: 8255565: [Vector API] Add missing format strings for extract instructs in x86.ad
  • 2c7fc85: 8254972: Fix pretouch chunk calculations
  • d128191: 8253473: Javadoc clean up in HttpHandler, HttpPrincipal, HttpContext, and HttpsConfigurator
  • 379ba80: 8255595: delay_to_keep_mmu passes wrong arguments to Monitor wait
  • 1a89d68: 8255285: Move JVMFlag origins into a new enum JVMFlagOrigin
  • 56eb5f5: 8255466: C2 crashes at ciObject::get_oop() const+0x0
  • 5782a2a: 8254975: lambda proxy fails to access a protected member inherited from a split package
  • ... and 6 more: https://git.openjdk.java.net/jdk/compare/faf23de54d81d70044d429f1081e10f2b6474e78...master

Your commit was automatically rebased without conflicts.

Pushed as commit 3fd8216.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
2 participants