Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8290080: G1: Remove unnecessary is-obj-dead check in HeapRegion::do_oops_on_memregion_in_humongous #9462

Closed

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Jul 12, 2022

Simple change of removing an if check.

Test: tier1-6


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8290080: G1: Remove unnecessary is-obj-dead check in HeapRegion::do_oops_on_memregion_in_humongous

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9462/head:pull/9462
$ git checkout pull/9462

Update a local copy of the PR:
$ git checkout pull/9462
$ git pull https://git.openjdk.org/jdk pull/9462/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9462

View PR using the GUI difftool:
$ git pr show -t 9462

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9462.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 12, 2022

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8290080 8290080: G1: Remove unnecessary is-obj-dead check in HeapRegion::do_oops_on_memregion_in_humongous Jul 12, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 12, 2022
@openjdk
Copy link

openjdk bot commented Jul 12, 2022

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Jul 12, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 12, 2022

Webrevs

Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@openjdk
Copy link

openjdk bot commented Jul 12, 2022

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290080: G1: Remove unnecessary is-obj-dead check in HeapRegion::do_oops_on_memregion_in_humongous

Reviewed-by: tschatzl, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 47 new commits pushed to the master branch:

  • 6e18883: 8290162: Reset recursion counter missed in fix of JDK-8224267
  • 31f7fc0: 8283082: sun.security.x509.X509CertImpl.delete("x509.info.validity") nulls out info field
  • d9ca438: Merge
  • 3164c98: 8289148: j.l.foreign.VaList::nextVarg call could throw IndexOutOfBoundsException or even crash the VM
  • c3806b9: 8289709: fatal error: stuck in JvmtiVTMSTransitionDisabler::disable_VTMS_transitions
  • 39715f3: 8287902: UnreadableRB case in MissingResourceCauseTest is not working reliably on Windows
  • 62fbc3f: 8287379: Using @inheritdoc in an inapplicable context shouldn't crash javadoc
  • fed3af8: 8287809: Revisit implementation of memory session
  • e8568b8: 8290020: Deadlock in leakprofiler::emit_events during shutdown
  • 7f0e9bd: 8289745: JfrStructCopyFailed uses heap words instead of bytes for object sizes
  • ... and 37 more: https://git.openjdk.org/jdk/compare/87aa3ce03e5e294b35cf2cab3cbba0d1964bbbff...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 12, 2022
@albertnetymk
Copy link
Member Author

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Jul 14, 2022

Going to push as commit 109e21a.
Since your change was applied there have been 70 commits pushed to the master branch:

  • adf40d2: 8290149: java/nio/file/Files/probeContentType/Basic.java fails on Windows Server 2019/2022
  • 292d909: 8290178: failure_handler: run netstat without name lookups
  • a7f8358: Merge
  • ce36f6e: 8290203: ProblemList vmTestbase/nsk/jvmti/scenarios/capability/CM03/cm03t001/TestDescription.java on linux-all
  • fff7f35: 8290201: ProblemList com/sun/jdi/InvokeHangTest.java on macosx-x64 in vthread mode
  • 128c6c6: 8290095: java/nio/channels/FileChannel/largeMemory/LargeGatheringWrite.java timed out
  • 59d0c73: 8289930: Improve Thread description of inherited AccessControlContext
  • 4545ed6: 8289365: SegmentAllocator:allocateArray(MemoryLayout, count) does not throw IAEx when count is -1
  • 0fd1b68: 8290071: Javadoc for MemorySegment/MemoryAddress getter/setters contains some typos
  • 2baf526: 8288850: SegmentAllocator:allocate() can return null some cases
  • ... and 60 more: https://git.openjdk.org/jdk/compare/87aa3ce03e5e294b35cf2cab3cbba0d1964bbbff...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 14, 2022
@openjdk openjdk bot closed this Jul 14, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 14, 2022
@openjdk
Copy link

openjdk bot commented Jul 14, 2022

@albertnetymk Pushed as commit 109e21a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the g1-remove-is-dead-check branch July 14, 2022 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
3 participants