Skip to content

8028265: Add legacy tz tests to OpenJDK #9476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
satoyoshiki wants to merge 2 commits into from
Closed

8028265: Add legacy tz tests to OpenJDK #9476

satoyoshiki wants to merge 2 commits into from

Conversation

@satoyoshiki
Copy link

@satoyoshiki satoyoshiki commented Jul 13, 2022 •
edited by openjdk bot
Loading

Please review this PR. The PR open sources the closed timezone tests.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9476/head:pull/9476
$ git checkout pull/9476

Update a local copy of the PR:
$ git checkout pull/9476
$ git pull https://git.openjdk.org/jdk pull/9476/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9476

View PR using the GUI difftool:
$ git pr show -t 9476

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9476.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 13, 2022

👋 Welcome back ysatowse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@satoyoshiki
Copy link
Author

satoyoshiki commented Jul 13, 2022

Can I ask you to help reviewing this PR?
@coffeys @naotoj

@openjdk
Copy link

openjdk bot commented Jul 13, 2022

@satoyoshiki The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Jul 13, 2022
coffeys
coffeys reviewed Jul 13, 2022
View reviewed changes
test/jdk/java/util/TimeZone/tools/share/Makefile Outdated
# make install
#

TZDATA = ../../../../../../../../open/src/java.base/share/data/tzdata
Copy link
Contributor

@coffeys coffeys Jul 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest you replace this with ../../../../../../../src/java.base/share/data/tzdata/

@coffeys
Copy link
Contributor

coffeys commented Jul 13, 2022

1 minor comment. Looks good to me.

@naotoj
Copy link
Member

naotoj commented Jul 13, 2022

Please modify the PR title to match the JBS.

@satoyoshiki satoyoshiki changed the title 8028265: Move closed timezone tests to open repository 8028265: Add legacy tz tests to OpenJDK Jul 14, 2022
@satoyoshiki satoyoshiki marked this pull request as ready for review July 14, 2022 04:22
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 14, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 14, 2022

Webrevs

coffeys
coffeys reviewed Jul 14, 2022
View reviewed changes
test/jdk/java/util/TimeZone/tools/share/makeZoneData.pl
Comment on lines +28 to +32
#
# For J2SE before JDK1.3, see ../../README how to update TimeZone.java
# static TimeZoneData.
# For J2SE since JDK1.4, this script is used to generate testdata(reference)
# for ZoneData.sh which is one of TimeZone Regression test.
Copy link
Contributor

@coffeys coffeys Jul 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest that you remove these lines - redundant information.

@openjdk
Copy link

openjdk bot commented Jul 14, 2022 •
edited
Loading

@satoyoshiki This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8028265: Add legacy tz tests to OpenJDK

Reviewed-by: coffeys, naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 79 new commits pushed to the master branch:

  • 757a742: 8290177: Improve documentation in G1MMUTracker
  • 890bced: 8290264: java/util/concurrent/locks/Lock/OOMEInAQS.java fails with "exit code: 0"
  • 3ad3950: Merge
  • fd89ab8: 8288112: C2: Error: ShouldNotReachHere() in Type::typerr()
  • 2bf6285: 8290209: jcup.md missing additional text
  • 73b83e0: 8290207: Missing notice in dom.md
  • 3bb2dc8: 8290290: Remove addition of TimeInstants
  • c7c2066: 8290221: G1: Merge multiple calls of get_next_marked_addr in HeapRegion::oops_on_memregion_iterate_in_unparsable
  • be58cbc: 8290269: gc/shenandoah/TestVerifyJCStress.java fails due to invalid tag: required after JDK-8290023
  • 109e21a: 8290080: G1: Remove unnecessary is-obj-dead check in HeapRegion::do_oops_on_memregion_in_humongous
  • ... and 69 more: https://git.openjdk.org/jdk/compare/e9d9cc6d0aece2237c490a610d79a562867251d8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@coffeys, @naotoj) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 14, 2022
@satoyoshiki
Copy link
Author

satoyoshiki commented Jul 15, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 15, 2022
@openjdk
Copy link

openjdk bot commented Jul 15, 2022

@satoyoshiki
Your change (at version 0dfda1b) is now ready to be sponsored by a Committer.

@coffeys
Copy link
Contributor

coffeys commented Jul 15, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 15, 2022

Going to push as commit 92deab5.
Since your change was applied there have been 80 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 15, 2022
@openjdk openjdk bot closed this Jul 15, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 15, 2022
@openjdk
Copy link

openjdk bot commented Jul 15, 2022

@coffeys @satoyoshiki Pushed as commit 92deab5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@naotoj naotoj naotoj approved these changes

@coffeys coffeys coffeys approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org integrated Pull request has been integrated

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@satoyoshiki @coffeys @naotoj