8290269: gc/shenandoah/TestVerifyJCStress.java fails due to invalid tag: required after JDK-8290023

[DamonFool]

Hi all,

Please review the trivial fix which fixes a typo (required --> requires).

Thanks.
Best regards,
Jie

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8290269: gc/shenandoah/TestVerifyJCStress.java fails due to invalid tag: required after JDK-8290023

Reviewers

• Thomas Schatzl (@tschatzl - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9485/head:pull/9485
$ git checkout pull/9485

Update a local copy of the PR:
$ git checkout pull/9485
$ git pull https://git.openjdk.org/jdk pull/9485/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9485

View PR using the GUI difftool:
$ git pr show -t 9485

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9485.diff

[bridgekeeper]

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@DamonFool The following labels will be automatically applied to this pull request:

• hotspot-gc
• shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (c9da1a78)

[tschatzl]

Lgtm and trivial

[openjdk]

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290269: gc/shenandoah/TestVerifyJCStress.java fails due to invalid tag: required after JDK-8290023

Reviewed-by: tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

• adf40d2: 8290149: java/nio/file/Files/probeContentType/Basic.java fails on Windows Server 2019/2022
• 292d909: 8290178: failure_handler: run netstat without name lookups
• a7f8358: Merge
• ce36f6e: 8290203: ProblemList vmTestbase/nsk/jvmti/scenarios/capability/CM03/cm03t001/TestDescription.java on linux-all
• fff7f35: 8290201: ProblemList com/sun/jdi/InvokeHangTest.java on macosx-x64 in vthread mode
• 128c6c6: 8290095: java/nio/channels/FileChannel/largeMemory/LargeGatheringWrite.java timed out
• 59d0c73: 8289930: Improve Thread description of inherited AccessControlContext
• 4545ed6: 8289365: SegmentAllocator:allocateArray(MemoryLayout, count) does not throw IAEx when count is -1
• 0fd1b68: 8290071: Javadoc for MemorySegment/MemoryAddress getter/setters contains some typos
• 2baf526: 8288850: SegmentAllocator:allocate() can return null some cases
• ... and 4 more: https://git.openjdk.org/jdk/compare/3216d198f382e991522600086bb2691abfe5f067...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tschatzl]

Also, apologies for the issue - I did not do release build runs with the change, and gha doesn't either.

[DamonFool]

Lgtm and trivial

Thanks @tschatzl for the review.
/integrate

[openjdk]

Going to push as commit be58cbc.
Since your change was applied there have been 15 commits pushed to the master branch:

• 109e21a: 8290080: G1: Remove unnecessary is-obj-dead check in HeapRegion::do_oops_on_memregion_in_humongous
• adf40d2: 8290149: java/nio/file/Files/probeContentType/Basic.java fails on Windows Server 2019/2022
• 292d909: 8290178: failure_handler: run netstat without name lookups
• a7f8358: Merge
• ce36f6e: 8290203: ProblemList vmTestbase/nsk/jvmti/scenarios/capability/CM03/cm03t001/TestDescription.java on linux-all
• fff7f35: 8290201: ProblemList com/sun/jdi/InvokeHangTest.java on macosx-x64 in vthread mode
• 128c6c6: 8290095: java/nio/channels/FileChannel/largeMemory/LargeGatheringWrite.java timed out
• 59d0c73: 8289930: Improve Thread description of inherited AccessControlContext
• 4545ed6: 8289365: SegmentAllocator:allocateArray(MemoryLayout, count) does not throw IAEx when count is -1
• 0fd1b68: 8290071: Javadoc for MemorySegment/MemoryAddress getter/setters contains some typos
• ... and 5 more: https://git.openjdk.org/jdk/compare/3216d198f382e991522600086bb2691abfe5f067...master

Your commit was automatically rebased without conflicts.

[openjdk]

@DamonFool Pushed as commit be58cbc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.