8290291: G1: Merge multiple calls of block_size in HeapRegion::block_start

[albertnetymk]

Simple change of merging duplicate inline calls. It reduces asm footprint, e.g. G1RemSet::refine_card_concurrently by ~200 bytes.

(The first commit is what I had originally -- inlining the block-walking logic, because block-walking logic is not used by others and highly specific to its sole caller. Ofc, this is subjective.)

Test: hotspot_gc

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8290291: G1: Merge multiple calls of block_size in HeapRegion::block_start

Reviewers

• Thomas Schatzl (@tschatzl - Reviewer)
• Ivan Walulya (@walulyai - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9490/head:pull/9490
$ git checkout pull/9490

Update a local copy of the PR:
$ git checkout pull/9490
$ git pull https://git.openjdk.org/jdk pull/9490/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9490

View PR using the GUI difftool:
$ git pr show -t 9490

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9490.diff

[bridgekeeper]

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@albertnetymk The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (8580eff1)

[tschatzl]

Lgtm.

[openjdk]

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290291: G1: Merge multiple calls of block_size in HeapRegion::block_start

Reviewed-by: tschatzl, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 309 new commits pushed to the master branch:

• 2712bc3: 8289741: Remove unused imports from DTDBuilder.java
• af243ca: 8265433: IGV: add graph tooltips with properties
• 7739843: 8288633: The ICC_ColorSpace.fromCIEXYZ method uses the wrong rendering intent
• eb8b789: 8292061: ProblemList serviceability/attach/ConcAttachTest.java on linux-all
• 08274e6: 8290975: Minor cleanup could be done in javax.security
• 7db5abd: 8282642: vmTestbase/gc/gctests/LoadUnloadGC2/LoadUnloadGC2.java fails intermittently with exit code 1
• 124fc4a: 8290180: Convert com/sun/management/UnixOperatingSystemMXBean/GetOpenFileDescriptorCount.sh to jtreg java version
• 4591937: 8290357: Drop HeapRegion::marked_bytes()
• 7676be8: 8291037: Move PLAB resizing mechanism to G1EvacStats
• 861cc67: 8291897: TerminatingThreadLocal(s) not registered from virtual thread(s)
• ... and 299 more: https://git.openjdk.org/jdk/compare/6e18883d8ffd9a7b7d495da05e9859dc1d1a2677...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[albertnetymk]

Thanks for the review.

/integrate

[openjdk]

Going to push as commit ec96b1f.
Since your change was applied there have been 370 commits pushed to the master branch:

• fd4b2f2: 8291718: Remove mark_for_deoptimization from klass unloading
• 9d7c13e: 8155246: Throw error if default java.security file is missing
• e89abb7: 8292190: [IR Framework] Remove redundant regex matching for failing counts constraints
• 77cd917: Merge
• 967a28c: 8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large
• 1c1c441: 8292072: NMT: repurpose Tracking overhead counter as global malloc counter
• d546d13: 8292319: ProblemList 2 runtime/cds/appcds tests due to JDK-8292313
• 8353a33: 8286313: [macos] Voice over reads the boolean value as null in the JTable
• e70747b: 8292305: [BACKOUT] JDK-8289208 Test DrawRotatedStringUsingRotatedFont.java occasionally crashes on MacOS
• 22d6d31: 8284313: Improve warning messages when CDS archive fails to load
• ... and 360 more: https://git.openjdk.org/jdk/compare/6e18883d8ffd9a7b7d495da05e9859dc1d1a2677...master

Your commit was automatically rebased without conflicts.

[openjdk]

@albertnetymk Pushed as commit ec96b1f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.