Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8288129: Shenandoah: Skynet test crashed with iu + aggressive #9494

Closed
wants to merge 7 commits into from

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Jul 14, 2022

Please review this patch to fix Loom test crash with Shenandoah IU mode.

Test:

  • hotspot_gc_shenandoah
  • jdk_loom with Shenandoah + IU
  • hotspot_loom with Shenandoah + IU

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8288129: Shenandoah: Skynet test crashed with iu + aggressive

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9494/head:pull/9494
$ git checkout pull/9494

Update a local copy of the PR:
$ git checkout pull/9494
$ git pull https://git.openjdk.org/jdk pull/9494/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9494

View PR using the GUI difftool:
$ git pr show -t 9494

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9494.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 14, 2022

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 14, 2022
@openjdk
Copy link

openjdk bot commented Jul 14, 2022

@zhengyu123 The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-gc hotspot-gc-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Jul 14, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 14, 2022

Webrevs

@zhengyu123 zhengyu123 marked this pull request as draft July 14, 2022 14:49
@openjdk openjdk bot removed the rfr Pull request is ready for review label Jul 14, 2022
@zhengyu123 zhengyu123 marked this pull request as ready for review July 14, 2022 15:31
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 14, 2022
@zhengyu123 zhengyu123 marked this pull request as draft July 14, 2022 15:54
@openjdk openjdk bot removed the rfr Pull request is ready for review label Jul 14, 2022
@zhengyu123 zhengyu123 closed this Jul 14, 2022
@zhengyu123 zhengyu123 deleted the JDK-8288129-iu-vthr branch July 14, 2022 16:40
Copy link
Contributor

@rkennke rkennke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@zhengyu123
Copy link
Contributor Author

Looks good to me.

I closed it. Unfortunately, the fix can still fail ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org
2 participants