Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8290278: JavaDoc of index parameter of method JTabbedPane.insertTab #9496

Closed
wants to merge 14 commits into from

Conversation

TejeshR13
Copy link
Contributor

@TejeshR13 TejeshR13 commented Jul 14, 2022

JavaDoc of JTabbedPane.inseetTab() is updated. The index position to insert a new tab ranges from 0 to TabCount(Position after the last tab position), the same is updated from > 0 to >= 0 .


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires a CSR request to be approved

Issues

  • JDK-8290278: JavaDoc of index parameter of method JTabbedPane.insertTab
  • JDK-8290420: JavaDoc of index parameter of method JTabbedPane.insertTab (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9496/head:pull/9496
$ git checkout pull/9496

Update a local copy of the PR:
$ git checkout pull/9496
$ git pull https://git.openjdk.org/jdk pull/9496/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9496

View PR using the GUI difftool:
$ git pr show -t 9496

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9496.diff

@TejeshR13 TejeshR13 changed the title 8290278 JavaDoc of index parameter of method JTabbedPane.insertTab 8290278: JavaDoc of index parameter of method JTabbedPane.insertTab Jul 14, 2022
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 14, 2022

👋 Welcome back tr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 14, 2022

⚠️ @TejeshR13 This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 14, 2022
@openjdk
Copy link

openjdk bot commented Jul 14, 2022

@TejeshR13 The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Jul 14, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 14, 2022

Webrevs

Copy link
Contributor

@prsadhuk prsadhuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check that it indeed accept 0 as a valid parameter and no exception is thrown?
Also, you need to raise a csr for this.

@TejeshR13
Copy link
Contributor Author

Did you check that it indeed accept 0 as a valid parameter and no exception is thrown? Also, you need to raise a csr for this.

Yes, I checked with 0 and have gone through the code as well. 0 position indicates index before 1st existing position and it ranges till tabcount. Index checking is done for < 0 to > tabCount().

@TejeshR13
Copy link
Contributor Author

I'll raise CSR......?

@prrace
Copy link
Contributor

prrace commented Jul 17, 2022

/csr

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Jul 17, 2022
@openjdk
Copy link

openjdk bot commented Jul 17, 2022

@prrace has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@TejeshR13 please create a CSR request for issue JDK-8290278 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

@TejeshR13
Copy link
Contributor Author

@prrace has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@TejeshR13 please create a CSR request for issue JDK-8290278 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

Yeah sure @prrace .

@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Jul 19, 2022
@openjdk
Copy link

openjdk bot commented Jul 19, 2022

@TejeshR13 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290278: JavaDoc of index parameter of method JTabbedPane.insertTab

Reviewed-by: psadhukhan, prr, honkar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 281 new commits pushed to the master branch:

  • 7739843: 8288633: The ICC_ColorSpace.fromCIEXYZ method uses the wrong rendering intent
  • eb8b789: 8292061: ProblemList serviceability/attach/ConcAttachTest.java on linux-all
  • 08274e6: 8290975: Minor cleanup could be done in javax.security
  • 7db5abd: 8282642: vmTestbase/gc/gctests/LoadUnloadGC2/LoadUnloadGC2.java fails intermittently with exit code 1
  • 124fc4a: 8290180: Convert com/sun/management/UnixOperatingSystemMXBean/GetOpenFileDescriptorCount.sh to jtreg java version
  • 4591937: 8290357: Drop HeapRegion::marked_bytes()
  • 7676be8: 8291037: Move PLAB resizing mechanism to G1EvacStats
  • 861cc67: 8291897: TerminatingThreadLocal(s) not registered from virtual thread(s)
  • 8d88be2: 8291459: JVM crash with GenerateOopMap::error_work(char const*, __va_list_tag*)
  • 8a804f6: 8291454: Missing check for JLI C runtime library in CoreLibraries.gmk
  • ... and 271 more: https://git.openjdk.org/jdk/compare/c7c20661eee727ed8354b19723c359ae7c2d4bd8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@prsadhuk, @prrace) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 19, 2022
@honkar-jdk
Copy link
Contributor

honkar-jdk commented Jul 22, 2022

Minor suggestion: how about we add index to the comparison?

{@code (index >= 0 && index <= getTabCount())} since index adds more clarity to the comparison and additionally to keep it consistent across the JTabbedPane similar to -

* {@code (index < 0 || index >= tab count)}

* {@code (index < 0 || index >= tab count)}

@TejeshR13
Copy link
Contributor Author

Minor suggestion: how about we add index to the comparison?

{@code (index >= 0 && index <= getTabCount())} since index adds more clarity to the comparison and additionally to keep it consistent across the JTabbedPane similar to -

* {@code (index < 0 || index >= tab count)}

* {@code (index < 0 || index >= tab count)}

Yeah @honkar-jdk , thank you for noticing it, will update it accordingly.

@openjdk openjdk bot added csr Pull request needs approved CSR before integration and removed ready Pull request is ready to be integrated labels Jul 27, 2022
@openjdk openjdk bot added ready Pull request is ready to be integrated and removed csr Pull request needs approved CSR before integration labels Aug 8, 2022
@TejeshR13
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 9, 2022
@openjdk
Copy link

openjdk bot commented Aug 9, 2022

@TejeshR13
Your change (at version a3d6ba4) is now ready to be sponsored by a Committer.

@prsadhuk
Copy link
Contributor

prsadhuk commented Aug 9, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 9, 2022

Going to push as commit cbc9040.
Since your change was applied there have been 283 commits pushed to the master branch:

  • 2712bc3: 8289741: Remove unused imports from DTDBuilder.java
  • af243ca: 8265433: IGV: add graph tooltips with properties
  • 7739843: 8288633: The ICC_ColorSpace.fromCIEXYZ method uses the wrong rendering intent
  • eb8b789: 8292061: ProblemList serviceability/attach/ConcAttachTest.java on linux-all
  • 08274e6: 8290975: Minor cleanup could be done in javax.security
  • 7db5abd: 8282642: vmTestbase/gc/gctests/LoadUnloadGC2/LoadUnloadGC2.java fails intermittently with exit code 1
  • 124fc4a: 8290180: Convert com/sun/management/UnixOperatingSystemMXBean/GetOpenFileDescriptorCount.sh to jtreg java version
  • 4591937: 8290357: Drop HeapRegion::marked_bytes()
  • 7676be8: 8291037: Move PLAB resizing mechanism to G1EvacStats
  • 861cc67: 8291897: TerminatingThreadLocal(s) not registered from virtual thread(s)
  • ... and 273 more: https://git.openjdk.org/jdk/compare/c7c20661eee727ed8354b19723c359ae7c2d4bd8...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 9, 2022
@openjdk openjdk bot closed this Aug 9, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 9, 2022
@openjdk
Copy link

openjdk bot commented Aug 9, 2022

@prsadhuk @TejeshR13 Pushed as commit cbc9040.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
4 participants