8252537: Updated @exception with @throws #95

Vipin-Sharma · 2020-09-09T19:29:30Z

Updated @exception with @throws for core-libs, it fixes all open sub-tasks of JDK-8252536.

Open Subtasks part of this fix are:

JDK-8252537
JDK-8252539
JDK-8252540
JDK-8252541

Previous conversation on this:
https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-September/068540.html

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issues

JDK-8252537: Updated @exception with @throws
JDK-8252536: Replace @exception with @throws for core-libs
JDK-8252539: Replace @exception with @throws java.rmi.activation package
JDK-8252540: Replace @exception with @throws java.rmi.registry package
JDK-8252541: Replace @exception with @throws java.rmi.server package

Reviewers

Roger Riggs (@RogerRiggs - Reviewer)
Serguei Spitsyn (@sspitsyn - Reviewer)
Lance Andersen (@LanceAndersen - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/95/head:pull/95
$ git checkout pull/95

bridgekeeper · 2020-09-09T19:31:50Z

👋 Welcome back vsharma! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2020-09-09T19:32:34Z

@Vipin-Sharma The following labels will be automatically applied to this pull request: core-libs serviceability.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label (add|remove) "label" command.

Vipin-Sharma · 2020-09-09T19:34:51Z

/issue 8252536,8252539,8252540,8252541

openjdk · 2020-09-09T19:35:50Z

@Vipin-Sharma
Adding additional issue to issue list: 8252536: Replace @exception with @throws for core-libs.

Adding additional issue to issue list: 8252539: Replace @exception with @throws java.rmi.activation package.

Adding additional issue to issue list: 8252540: Replace @exception with @throws java.rmi.registry package.

Adding additional issue to issue list: 8252541: Replace @exception with @throws java.rmi.server package.

mlbridge · 2020-09-09T19:38:55Z

Webrevs

03: Full - Incremental (b9ed657)
02: Full (37b6936)
01: Full - Incremental (e99534664993de6d4d489db1bcdffce94bf932a5)
00: Full (a84158ace80ebe10e0d07223ac1878e4e4fedd6c)

mlbridge · 2020-09-14T19:13:17Z

Mailing list message from serguei.spitsyn at oracle.com on serviceability-dev:

An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20200914/45376ba9/attachment.htm>

RogerRiggs

Please re-indent the @throws lines to add 3 spaces after so that the comments are aligned as they were previously.

sspitsyn

I've only looked at the management files. They look good in general.

src/java.management/share/classes/java/lang/management/ClassLoadingMXBean.java

108 * @throws java.lang.SecurityException if a security manager
109 * exists and the caller does not have
110 * ManagementPermission("control").

src/java.management/share/classes/java/lang/management/MemoryMXBean.java

286 * @throws java.lang.SecurityException if a security manager
287 * exists and the caller does not have
288 * ManagementPermission("control").

Could you, please, fix the indentation?

Vipin-Sharma · 2020-09-15T19:13:55Z

@RogerRiggs I understand your point and will update PR with correct indentation.
But I think adding 3 spaces after throws may not be right for all cases.
For example when

Another tag in same method is using only 1 space.
In some cases (e.g. free method of Blob.java) we had a mix of throws and exception in the same method both with one space after. Here after adding 3 spaces throws tags will have the different number of spaces and indentation will not be same as before.

I will update PR to make sure the indentation looks same as before and there is no change in javadoc.
Please tell me in case my understnding is not correct here.

RogerRiggs · 2020-09-15T19:19:07Z

HI Vipin, Correct, a better description is "fix the indentation". I mnetioned 3 because that was the difference in length between "exception" and "throws". Thanks for the followup, Roger

…

On 9/15/20 3:14 PM, Vipin Sharma wrote: @RogerRiggs <https://urldefense.com/v3/__https://github.com/RogerRiggs__;!!GqivPVa7Brio!IQp3U9OccSzrjwI7nzJl491MGc8URG355lsnpdvFTIOGQcgmRGlpC-Kpz3kh64J6$> I understand your point and will update PR with correct indentation. But I think adding 3 spaces after throws may not be right for all cases. For example when 1. Another tag in same method is using only 1 space. 2. In some cases (e.g. free method of Blob.java) we had a mix of throws and exception in the same method both with one space after. Here after adding 3 spaces throws tags will have the different number of spaces and indentation will not be same as before. I will update PR to make sure the indentation looks same as before and there is no change in javadoc. Please tell me in case my understnding is not correct here. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/95*issuecomment-692922280__;Iw!!GqivPVa7Brio!IQp3U9OccSzrjwI7nzJl491MGc8URG355lsnpdvFTIOGQcgmRGlpC-Kpz78EqgGt$>, or unsubscribe <https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AAIRSVAMITTR62U3YVETCM3SF64IFANCNFSM4RDCQ4MA__;!!GqivPVa7Brio!IQp3U9OccSzrjwI7nzJl491MGc8URG355lsnpdvFTIOGQcgmRGlpC-Kpz1RGWzIm$>.

openjdk · 2020-09-19T14:44:39Z

⚠️ @Vipin-Sharma This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

Vipin-Sharma · 2020-09-19T14:55:28Z

There was something wrong with the way I updated this PR, please ignore this. I will try to correct this or will close this PR and create a new one.

sspitsyn

I've reviewed the management files only. They look good.

openjdk · 2020-09-20T22:38:08Z

@Vipin-Sharma This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8252537: Updated @exception with @throws
8252536: Replace @exception with @throws for core-libs
8252539: Replace @exception with @throws java.rmi.activation package
8252540: Replace @exception with @throws java.rmi.registry package
8252541: Replace @exception with @throws java.rmi.server package

Reviewed-by: rriggs, sspitsyn, lancea

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 178 new commits pushed to the master branch:

4185ed3: 5078989: Null Pointer exception in SpinnerListMode
6f40a41: 8253891: Debug x86_32 builds fail after JDK-8239090
b9505df: 8253118: Avoid unnecessary deopts when OSR nmethods of the same level are present.
3c4e824: 8249783: Simplify DerValue and DerInputStream
9230c2a: 8253747: tools/jpackage/share/AppImagePackageTest.java fails with InstalledPackageSize: 0
cfd41c0: 8232840: java/math/BigInteger/largeMemory/SymmetricRangeTests.java fails due to "OutOfMemoryError: Requested array size exceeds VM limit"
8fda5b8: 8253904: Revert Tokenizer improvements JDK-8224225
60ec2a5: 8253824: Revert JDK-8253089 since VS warning C4307 has been disabled
90c131f: 8224225: Tokenizer improvements
9670425: 8253822: Remove unused exception_address_is_unpack_entry
... and 168 more: https://git.openjdk.java.net/jdk/compare/d27835b34e713a80ff6277432f830333d5c4ea17...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RogerRiggs, @sspitsyn, @LanceAndersen) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

LanceAndersen

Overall the changes look OK. in the java.sql set of classes, please updated the modified statements to also use {@code}

LanceAndersen · 2020-09-24T17:12:19Z

src/java.sql/share/classes/java/sql/CallableStatement.java

     * if a database access error occurs or
     * this method is called on a closed <code>CallableStatement</code>
-     * @exception SQLFeatureNotSupportedException if <code>sqlType</code> is
+     * @throws SQLFeatureNotSupportedException if <code>sqlType</code> is
     * a <code>ARRAY</code>, <code>BLOB</code>, <code>CLOB</code>,
     * <code>DATALINK</code>, <code>JAVA_OBJECT</code>, <code>NCHAR</code>,
     * <code>NCLOB</code>, <code>NVARCHAR</code>, <code>LONGNVARCHAR</code>,


Please change to use {@code) as part of the update

LanceAndersen · 2020-09-24T17:13:37Z

src/java.sql/share/classes/java/sql/CallableStatement.java

     * if a database access error occurs or
     * this method is called on a closed <code>CallableStatement</code>
-     * @exception SQLFeatureNotSupportedException if <code>sqlType</code> is
+     * @throws SQLFeatureNotSupportedException if <code>sqlType</code> is
     * a <code>ARRAY</code>, <code>BLOB</code>, <code>CLOB</code>,
     * <code>DATALINK</code>, <code>JAVA_OBJECT</code>, <code>NCHAR</code>,
     * <code>NCLOB</code>, <code>NVARCHAR</code>, <code>LONGNVARCHAR</code>,


Same comment regarding {@code}

Vipin-Sharma · 2020-09-24T18:20:15Z

Overall the changes look OK. in the java.sql set of classes, please updated the modified statements to also use {@code}

Hi @LanceAndersen, it was suggested by @RogerRiggs also. I have created a separate bug JDK-8253612 to fix this for all java.sql and all other core-libs classes.
Following is earlier discussion on this.
https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-September/068510.html

LanceAndersen · 2020-09-24T18:28:33Z

Overall the changes look OK. in the java.sql set of classes, please updated the modified statements to also use {@code}

Hi @LanceAndersen, it was suggested by @RogerRiggs also. I have created a separate bug JDK-8253612 to fix this for all java.sql and all other core-libs classes.
Following is earlier discussion on this.
https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-September/068510.html

Hi Vipin, I agree overall that to replace all of places in the JDK with {@code} where needed should be a separate task with an umbrella issue with a subtask for each module. Unless there are a large number of other exceptions that are being modified and require updates for {@code} I would prefer to have it done as part of this set of changes

…java.sql

LanceAndersen

The changes look good. Thank you for addressing this.

Vipin-Sharma · 2020-10-02T10:40:01Z

/integrate

openjdk · 2020-10-02T10:40:47Z

@Vipin-Sharma
Your change (at version b9ed657) is now ready to be sponsored by a Committer.

LanceAndersen · 2020-10-02T14:41:49Z

/integrate

openjdk · 2020-10-02T14:42:08Z

@LanceAndersen Only the author (@Vipin-Sharma) is allowed to issue the integrate command. As this PR is ready to be sponsored, and you are an eligible sponsor, did you mean to issue the /sponsor command?

LanceAndersen · 2020-10-02T14:50:16Z

/sponsor

openjdk · 2020-10-02T14:51:16Z

@LanceAndersen @Vipin-Sharma Since your change was applied there have been 185 commits pushed to the master branch:

406db1c: 8253913: unify gtest test names
ea5a2b1: 8251464: make Node::dump(int depth) support indent
fff8c8d: 8253882: remove PropertyResolvingWrapper
7dcdc1f: 8253865: Pre-submit testing using GitHub Actions does not detect failures reliably
0fd41c3: 8253470: Javadoc clean up in Filter and Headers
f686a38: 8253926: Use extra_size correctly in anon_mmap_aligned
b8966e1: 8253928: G1: Remove G1ConcurrentMarkThread::set_in_progress declaration
4185ed3: 5078989: Null Pointer exception in SpinnerListMode
6f40a41: 8253891: Debug x86_32 builds fail after JDK-8239090
b9505df: 8253118: Avoid unnecessary deopts when OSR nmethods of the same level are present.
... and 175 more: https://git.openjdk.java.net/jdk/compare/d27835b34e713a80ff6277432f830333d5c4ea17...master

Your commit was automatically rebased without conflicts.

Pushed as commit dffe9db.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

* Use pthread_set_name_np to set the thread name on FreeBSD Originally authored by: bra@fsn.hu (openjdk8) Forward ported by: huanghwh Issue openjdk#95

)

…njdk#95

openjdk bot added the rfr Pull request is ready for review label Sep 9, 2020

openjdk bot added serviceability serviceability-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels Sep 9, 2020

RogerRiggs suggested changes Sep 14, 2020

View reviewed changes

sspitsyn suggested changes Sep 15, 2020

View reviewed changes

Vipin-Sharma marked this pull request as draft September 19, 2020 14:57

openjdk bot removed the rfr Pull request is ready for review label Sep 19, 2020

JDK-8252537 Updated @exception with @throws, implemented review comments

37b6936

Vipin-Sharma force-pushed the JDK-8252537 branch from e995346 to 37b6936 Compare September 19, 2020 20:20

Vipin-Sharma marked this pull request as ready for review September 19, 2020 20:28

openjdk bot added the rfr Pull request is ready for review label Sep 19, 2020

sspitsyn approved these changes Sep 20, 2020

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Sep 20, 2020

LanceAndersen suggested changes Sep 24, 2020

View reviewed changes

Replaced <code>...</code> with {@code ...} for modified statement in …

b9ed657

…java.sql

LanceAndersen approved these changes Sep 28, 2020

View reviewed changes

openjdk bot removed the ready Pull request is ready to be integrated label Sep 28, 2020

RogerRiggs approved these changes Sep 28, 2020

View reviewed changes

rwestberg added the recheck label Sep 30, 2020

openjdk bot added the ready Pull request is ready to be integrated label Sep 30, 2020

rwestberg removed the recheck label Sep 30, 2020

sspitsyn approved these changes Oct 1, 2020

View reviewed changes

openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 2, 2020

openjdk bot closed this Oct 2, 2020

openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 2, 2020

dankm pushed a commit to dankm/openjdk that referenced this pull request Oct 27, 2020

Support setting thread names on FreeBSD

8efe8e1

* Use pthread_set_name_np to set the thread name on FreeBSD Originally authored by: bra@fsn.hu (openjdk8) Forward ported by: huanghwh Issue openjdk#95

robehn pushed a commit to robehn/jdk that referenced this pull request Aug 15, 2023

SW-3506: Add vtable/itable index to the JVMTI code gen event (openjdk#95

f2751e2

)

pfirmstone pushed a commit to pfirmstone/jdk-with-authorization that referenced this pull request Nov 18, 2024

remove java.ext.dirs property in security policy files in Java 11 ope…

1dfeefc

…njdk#95

pfirmstone pushed a commit to pfirmstone/jdk-with-authorization that referenced this pull request Nov 18, 2024

remove java.ext.dirs property in security policy files in Java 11 ope…

b7ea7ac

…njdk#95

pfirmstone pushed a commit to pfirmstone/jdk-with-authorization that referenced this pull request Nov 18, 2024

remove java.ext.dirs property in security policy files in Java 11 ope…

55cbd44

…njdk#95

pfirmstone pushed a commit to pfirmstone/jdk-with-authorization that referenced this pull request Nov 18, 2024

remove java.ext.dirs property in security policy files in Java 11 ope…

f19ad18

…njdk#95

pfirmstone pushed a commit to pfirmstone/jdk-with-authorization that referenced this pull request Nov 18, 2024

remove java.ext.dirs property in security policy files in Java 11 ope…

8db94ee

…njdk#95

pfirmstone pushed a commit to pfirmstone/jdk-with-authorization that referenced this pull request Nov 18, 2024

remove java.ext.dirs property in security policy files in Java 11 ope…

e6dbcd8

…njdk#95

pfirmstone pushed a commit to pfirmstone/jdk-with-authorization that referenced this pull request Nov 18, 2024

remove java.ext.dirs property in security policy files in Java 11 ope…

c3cab2d

…njdk#95

pfirmstone pushed a commit to pfirmstone/jdk-with-authorization that referenced this pull request Nov 18, 2024

remove java.ext.dirs property in security policy files in Java 11 ope…

c74f04b

…njdk#95

pfirmstone pushed a commit to pfirmstone/jdk-with-authorization that referenced this pull request Nov 18, 2024

remove java.ext.dirs property in security policy files in Java 11 ope…

a1b748a

…njdk#95

pfirmstone pushed a commit to pfirmstone/jdk-with-authorization that referenced this pull request Nov 18, 2024

remove java.ext.dirs property in security policy files in Java 11 ope…

191a7d9

…njdk#95

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8252537: Updated @exception with @throws #95

8252537: Updated @exception with @throws #95

Vipin-Sharma commented Sep 9, 2020 •

edited by openjdk bot

Loading

bridgekeeper bot commented Sep 9, 2020

openjdk bot commented Sep 9, 2020

Vipin-Sharma commented Sep 9, 2020

openjdk bot commented Sep 9, 2020

mlbridge bot commented Sep 9, 2020 •

edited

Loading

mlbridge bot commented Sep 14, 2020

RogerRiggs left a comment

sspitsyn left a comment

Vipin-Sharma commented Sep 15, 2020

RogerRiggs commented Sep 15, 2020 via email

openjdk bot commented Sep 19, 2020

Vipin-Sharma commented Sep 19, 2020

sspitsyn left a comment

openjdk bot commented Sep 20, 2020 •

edited

Loading

LanceAndersen left a comment

LanceAndersen Sep 24, 2020

LanceAndersen Sep 24, 2020

Vipin-Sharma commented Sep 24, 2020

LanceAndersen commented Sep 24, 2020

LanceAndersen left a comment

Vipin-Sharma commented Oct 2, 2020

openjdk bot commented Oct 2, 2020

LanceAndersen commented Oct 2, 2020

openjdk bot commented Oct 2, 2020

LanceAndersen commented Oct 2, 2020

openjdk bot commented Oct 2, 2020

8252537: Updated @exception with @throws #95

8252537: Updated @exception with @throws #95

Conversation

Vipin-Sharma commented Sep 9, 2020 • edited by openjdk bot Loading

Progress

Issues

Reviewers

Download

bridgekeeper bot commented Sep 9, 2020

openjdk bot commented Sep 9, 2020

Vipin-Sharma commented Sep 9, 2020

openjdk bot commented Sep 9, 2020

mlbridge bot commented Sep 9, 2020 • edited Loading

Webrevs

mlbridge bot commented Sep 14, 2020

RogerRiggs left a comment

Choose a reason for hiding this comment

sspitsyn left a comment

Choose a reason for hiding this comment

Vipin-Sharma commented Sep 15, 2020

RogerRiggs commented Sep 15, 2020 via email

openjdk bot commented Sep 19, 2020

Vipin-Sharma commented Sep 19, 2020

sspitsyn left a comment

Choose a reason for hiding this comment

openjdk bot commented Sep 20, 2020 • edited Loading

LanceAndersen left a comment

Choose a reason for hiding this comment

LanceAndersen Sep 24, 2020

Choose a reason for hiding this comment

LanceAndersen Sep 24, 2020

Choose a reason for hiding this comment

Vipin-Sharma commented Sep 24, 2020

LanceAndersen commented Sep 24, 2020

LanceAndersen left a comment

Choose a reason for hiding this comment

Vipin-Sharma commented Oct 2, 2020

openjdk bot commented Oct 2, 2020

LanceAndersen commented Oct 2, 2020

openjdk bot commented Oct 2, 2020

LanceAndersen commented Oct 2, 2020

openjdk bot commented Oct 2, 2020

Vipin-Sharma commented Sep 9, 2020 •

edited by openjdk bot

Loading

mlbridge bot commented Sep 9, 2020 •

edited

Loading

openjdk bot commented Sep 20, 2020 •

edited

Loading