Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8196099: javax/swing/text/CSSBorder/6796710/bug6796710.java fails #950

Closed
wants to merge 3 commits into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Oct 30, 2020

This test could fail on windows for two reasons:

  • The window does not fit the small screen, and the robot captures the image outside the screen. Especially if the screen is small but some scale (like 150%) is set.
  • The test paints and captures the button in the frame, then resize the frame and again paint and captures the button. The problem occurs if the fractional scale is used(like 125%), in that case, the button could be shifted by one pixel due to rounding depending on what position it was started to be drawn.

The solution is to always use the same uiscale=1, an updated test still can reproduce the JDK-6796710


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Linux x86 Windows x64 macOS x64
Build ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Issue

  • JDK-8196099: javax/swing/text/CSSBorder/6796710/bug6796710.java fails

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/950/head:pull/950
$ git checkout pull/950

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 30, 2020

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 30, 2020
@openjdk
Copy link

openjdk bot commented Oct 30, 2020

@mrserb The following label will be automatically applied to this pull request:

  • swing

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the swing client-libs-dev@openjdk.org label Oct 30, 2020
@mlbridge
Copy link

mlbridge bot commented Oct 30, 2020

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 31, 2020

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8196099: javax/swing/text/CSSBorder/6796710/bug6796710.java fails

Reviewed-by: psadhukhan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

  • cacce84: 8169954: JFileChooser/8021253: java.lang.RuntimeException: Default button is not pressed
  • 7597cba: 8143021: [TEST_BUG] Test javax/swing/JColorChooser/Test6541987.java fails
  • 80380d5: 8255494: PKCS7 should use digest algorithm to verify the signature
  • 9d5c9cc: 8254309: appcds GCDuringDump.java failed - class must exist
  • 36c150b: 8255489: Unify the parsing of @lambda-proxy and @lambda-form-invokers tags in a classlist
  • 0f48603: 8214561: Use {@systemProperty} for definition of "java.util.prefs.PreferencesFactory" system property
  • 98a69ed: 8255690: &nbsp in StringBuilder.subSequence
  • 4158567: 8255455: Pre-generate ThreadHeapSampler::_log_table
  • d086757: 8254052: improve type specificity of TagletWriter and friends
  • 8600d0d: 8255614: Shenandoah: Consolidate/streamline runtime LRBs
  • ... and 10 more: https://git.openjdk.java.net/jdk/compare/56eb5f54f40d2e1c3bdfbf440f2c5e1572639bc9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 31, 2020
@mrserb
Copy link
Member Author

mrserb commented Oct 31, 2020

/integrate

@openjdk openjdk bot closed this Oct 31, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 31, 2020
@openjdk
Copy link

openjdk bot commented Oct 31, 2020

@mrserb Since your change was applied there have been 20 commits pushed to the master branch:

  • cacce84: 8169954: JFileChooser/8021253: java.lang.RuntimeException: Default button is not pressed
  • 7597cba: 8143021: [TEST_BUG] Test javax/swing/JColorChooser/Test6541987.java fails
  • 80380d5: 8255494: PKCS7 should use digest algorithm to verify the signature
  • 9d5c9cc: 8254309: appcds GCDuringDump.java failed - class must exist
  • 36c150b: 8255489: Unify the parsing of @lambda-proxy and @lambda-form-invokers tags in a classlist
  • 0f48603: 8214561: Use {@systemProperty} for definition of "java.util.prefs.PreferencesFactory" system property
  • 98a69ed: 8255690: &nbsp in StringBuilder.subSequence
  • 4158567: 8255455: Pre-generate ThreadHeapSampler::_log_table
  • d086757: 8254052: improve type specificity of TagletWriter and friends
  • 8600d0d: 8255614: Shenandoah: Consolidate/streamline runtime LRBs
  • ... and 10 more: https://git.openjdk.java.net/jdk/compare/56eb5f54f40d2e1c3bdfbf440f2c5e1572639bc9...master

Your commit was automatically rebased without conflicts.

Pushed as commit fe7672b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated swing client-libs-dev@openjdk.org
2 participants