Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8289003: JavaThread::check_is_terminated() implementation should rely on Thread-SMR #9502

Closed
wants to merge 2 commits into from
Closed

8289003: JavaThread::check_is_terminated() implementation should rely on Thread-SMR #9502

wants to merge 2 commits into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Jul 14, 2022 •
edited by openjdk bot
Loading

A small fix to change JavaThread::check_is_terminated() to rely on Thread-SMR.
The change is textually trivial, but requires a bit of thinking about the JavaThread
lifecycle. Since this is a cleanup of some old Thread-SMR related changes, I also
took the time to cleanup some comments and white space while I was visiting the
uses of _vm_exited.

Mach5 Tier1 has no related failures. Mach5 Tier[23] testing has just started.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8289003: JavaThread::check_is_terminated() implementation should rely on Thread-SMR

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9502/head:pull/9502
$ git checkout pull/9502

Update a local copy of the PR:
$ git checkout pull/9502
$ git pull https://git.openjdk.org/jdk pull/9502/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9502

View PR using the GUI difftool:
$ git pr show -t 9502

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9502.diff

@dcubed-ojdk
Copy link
Member Author

/label add hotspot-runtime

@dcubed-ojdk
Copy link
Member Author

@dholmes-ora - Please review when you get the chance.

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review July 14, 2022 21:50
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 14, 2022

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr Pull request is ready for review hotspot-runtime hotspot-runtime-dev@openjdk.org labels Jul 14, 2022
@openjdk
Copy link

openjdk bot commented Jul 14, 2022

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Jul 14, 2022 •
edited
Loading

Webrevs

dholmes-ora
dholmes-ora approved these changes Jul 15, 2022
View reviewed changes
Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

Thanks,
David

src/hotspot/share/runtime/javaThread.hpp Outdated
// against the three non-terminated values so that a freed JavaThread
// will also be considered terminated.
// thread is terminated (no longer on the threads list); the thread must
// protected by a ThreadsListHandle to avoid potential crashes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// be protected ...

@openjdk
Copy link

openjdk bot commented Jul 15, 2022 •
edited
Loading

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289003: JavaThread::check_is_terminated() implementation should rely on Thread-SMR

Reviewed-by: dholmes, pchilanomate

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 15, 2022
@dcubed-ojdk
Copy link
Member Author

@dholmes-ora - Thanks for the review and for catching the typo. Will fix shortly.
Got hit by a thunderstorm last night so I'm still trying to figure out what all got fried...

@dcubed-ojdk
Copy link
Member Author

dcubed-ojdk commented Jul 15, 2022 •
edited
Loading

@coleenp, @fisk, @robehn or @pchilano - I need one more review from someone that has
been in the Thread-SMR code, if you can spare a few cycles...

pchilano
pchilano approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@pchilano pchilano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dcubed-ojdk
Copy link
Member Author

@pchilano - Thanks for the review.

@dcubed-ojdk
Copy link
Member Author

Mach5 Tier[1-7] testing looks good.

/integrate

@openjdk
Copy link

openjdk bot commented Jul 16, 2022

Going to push as commit 441c33f.
Since your change was applied there have been 34 commits pushed to the master branch:

  • 2342684: 8290066: Remove KNL specific handling for new CPU target check in IR annotation
  • 0143cf1: 8290333: Remove os_share_*.hpp
  • 0184f46: 8289919: [test] LoadLibraryUnloadTest.java failed with "Failed to unload native library"
  • cca91f7: 8290327: Remove java/lang/reflect/callerCache/ReflectionCallerCacheTest.java from ProblemList-Xcomp.txt
  • b4e2ce0: 8290366: Remove unused during_conc_mark parameter in HeapRegion::note_self_forwarding_removal_start
  • f3abb82: 8268312: Compilation error with nested generic functional interface
  • 92deab5: 8028265: Add legacy tz tests to OpenJDK
  • 70fce07: 8290246: test fails "assert(init != __null) failed: initialization not found"
  • 757a742: 8290177: Improve documentation in G1MMUTracker
  • 890bced: 8290264: java/util/concurrent/locks/Lock/OOMEInAQS.java fails with "exit code: 0"
  • ... and 24 more: https://git.openjdk.org/jdk/compare/74ac5df96fb4344f005180f8643cb0c9223b1556...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 16, 2022
@openjdk openjdk bot closed this Jul 16, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 16, 2022
@openjdk
Copy link

openjdk bot commented Jul 16, 2022

@dcubed-ojdk Pushed as commit 441c33f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8289003 branch August 11, 2022 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchilano pchilano pchilano approved these changes

@dholmes-ora dholmes-ora dholmes-ora approved these changes

Assignees
No one assigned
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dcubed-ojdk @pchilano @dholmes-ora