Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8283707: Support <major.minor.update.build> version format on Windows #9507

Closed

Conversation

alexeysemenyukoracle
Copy link
Member

@alexeysemenyukoracle alexeysemenyukoracle commented Jul 15, 2022


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8283707: Support <major.minor.update.build> version format on Windows

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9507/head:pull/9507
$ git checkout pull/9507

Update a local copy of the PR:
$ git checkout pull/9507
$ git pull https://git.openjdk.org/jdk pull/9507/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9507

View PR using the GUI difftool:
$ git pr show -t 9507

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9507.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 15, 2022

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 15, 2022

@alexeysemenyukoracle The following labels will be automatically applied to this pull request:

  • build
  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added build build-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels Jul 15, 2022
Fix FindRelatedProductsEx CA to gracefully handle missing Upgrade table case.
Fix FindRelatedProductsEx CA to properly match version of a found product against MinVersion and MaxVersion values of Upgrade table rows.
@alexeysemenyukoracle alexeysemenyukoracle marked this pull request as ready for review July 16, 2022 19:41
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 16, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 16, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 18, 2022

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283707: Support <major.minor.update.build> version format on Windows

Reviewed-by: almatvee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 532 new commits pushed to the master branch:

  • 5a96a5d: 8289612: Change hotspot/jtreg tests to not use Thread.stop
  • b65f7ec: 4887998: Use Integer.rotateLeft() and rotateRight() in crypto implementations
  • 6c8d0e6: 8282526: Default icon is not painted properly
  • e72742e: 8286172: Create an automated test for JDK-4516019
  • b9de0a7: 8284524: Create an automated test for JDK-4422362
  • 5ae4320: 8284767: Create an automated test for JDK-4422535
  • efed7a7: 8289908: Skip bounds check for cases when String is constructed from entirely used byte[]
  • b2010a7: 8287805: Shenandoah: consolidate evacuate-update-root closures
  • ea8b75c: 8290334: Update FreeType to 2.12.1
  • 6882f0e: 8290013: serviceability/jvmti/GetLocalVariable/GetLocalWithoutSuspendTest.java failed "assert(!in_vm) failed: Undersized StackShadowPages"
  • ... and 522 more: https://git.openjdk.org/jdk/compare/1aa87e0078765480bc7805e95b747addaf993cf6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 18, 2022
@alexeysemenyukoracle
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 19, 2022

Going to push as commit 977e094.
Since your change was applied there have been 548 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 19, 2022
@openjdk openjdk bot closed this Jul 19, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 19, 2022
@openjdk
Copy link

openjdk bot commented Jul 19, 2022

@alexeysemenyukoracle Pushed as commit 977e094.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants