8290300: Use standard String-joining tools where applicable

[stsypanov]

Simplify code with String.join()

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8290300: Use standard String-joining tools where applicable

Reviewers

• Naoto Sato (@naotoj - Reviewer)
• Roger Riggs (@RogerRiggs - Reviewer)
• Daniel Fuchs (@dfuch - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9513/head:pull/9513
$ git checkout pull/9513

Update a local copy of the PR:
$ git checkout pull/9513
$ git pull https://git.openjdk.org/jdk pull/9513/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9513

View PR using the GUI difftool:
$ git pr show -t 9513

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9513.diff

[bridgekeeper]

👋 Welcome back stsypanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@stsypanov The following labels will be automatically applied to this pull request:

• core-libs
• i18n
• net
• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 04: Full - Incremental (af555897)
• 03: Full - Incremental (5b18c39c)
• 02: Full - Incremental (4f2bbfd3)
• 01: Full - Incremental (80384470)
• 00: Full (f3020263)

[JimLaskey]

LGTM, however are there tests that ensure the changes are benign?

[AlanBateman]

joptsimple is a 3rd party code so we probably don't want to change that.

[stsypanov]

Reverted jops

[stsypanov]

@JimLaskey I'll double check and add tests if necessary

[naotoj]

Changes to Locale look good to me.

[openjdk]

⚠️ @stsypanov the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout 8290300
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

[openjdk]

@stsypanov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290300: Use standard String-joining tools where applicable

Reviewed-by: naoto, rriggs, dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 213 new commits pushed to the master branch:

• 0971d34: Merge
• 54c093a: 8291524: jdk/jfr/event/runtime/TestClassLoaderStatsEvent.java Value not equal to 2, field='hiddenClassCount', value='0'
• 1d16c91: 8291512: Snippetize modules API examples
• 0ae8341: 8290908: misc tests fail: assert(!thread->owns_locks()) failed: must release all locks when leaving VM
• 5acf2d7: 8291578: Remove JMX related tests from ProblemList-svc-vthreads.txt
• a6564d4: 8291650: Add delay to ClassUnloadEventTest before exiting to give time for JVM to send all events before VMDeath
• af76c0c: 8291654: AArch64: assert from JDK-8287393 causes crashes
• a9db5bb: 8291626: Remove Mutex::contains as it is unused
• a2cff26: 8291597: [BACKOUT] JDK-8289996: Fix array range check hoisting for some scaled loop iv
• 554f44e: 8282730: LdapLoginModule throw NPE from logout method after login failure
• ... and 203 more: https://git.openjdk.org/jdk/compare/c7c20661eee727ed8354b19723c359ae7c2d4bd8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@JimLaskey, @naotoj, @RogerRiggs, @dfuch) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[stsypanov]

@JimLaskey changes in WindowsPath are covered by PathOps, apart from this there are 10 tests calling this method.

ProcessBuilder is covered with TestProcessStart.

For Locale all the call sites of formatList() never pass null, so the code in if block is never executed. I think we can delete this unused parts of the code in Locale, but I'm not sure about ProcessBuilder.

[naotoj]

For Locale all the call sites of formatList() never pass null, so the code in if block is never executed. I think we can delete this unused parts of the code in Locale,

Are you sure about this? pattern is derived from LocaleResources.getLocaleName() which could return null.

[stsypanov]

Right, my bad. I've confused arguments. The changes reverted.

[stsypanov]

/integrate

[openjdk]

@stsypanov
Your change (at version af55589) is now ready to be sponsored by a Committer.

[dfuch]

Changes to HttpURLConnection look good to me

[stsypanov]

Anyone to sponsor?

[cl4es]

/sponsor

[openjdk]

Going to push as commit 9a65524.
Since your change was applied there have been 418 commits pushed to the master branch:

• f9004fe: 8292561: Make "ReplayCompiles" a diagnostic product switch
• 2fbb936: 8292691: Move CompilerConfig::is_xxx() inline functions out of compilerDefinitions.hpp
• 3601e30: 8290909: MemoryPoolMBean/isUsageThresholdExceeded tests failed with "isUsageThresholdExceeded() returned false, and is still false, while threshold = MMMMMMM and used peak = NNNNNNN"
• 37c0a13: 8292350: Use static methods for hashCode/toString primitives
• 4453200: 8292628: x86: Improve handling of constants in trigonometric stubs
• 07c9ba7: 8292686: runtime/cds/appcds/TestWithProfiler.java SIGSEGV in TableStatistics ctr
• 235151e: 8292676: Remove two kerberos tests from problem list
• df5209e: 8292683: Remove BadKeyUsageTest.java from Problem List
• 74d3330: 8292682: Code change of JDK-8282730 not updated to reflect CSR update
• 57aac2a: 8290981: Enable CDS for zero builds
• ... and 408 more: https://git.openjdk.org/jdk/compare/c7c20661eee727ed8354b19723c359ae7c2d4bd8...master

Your commit was automatically rebased without conflicts.

[openjdk]

@cl4es @stsypanov Pushed as commit 9a65524.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[stsypanov]

Thanks!