Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8290359: Ensure that all directory streams are closed in jdk.link #9520

Closed
wants to merge 3 commits into from

Conversation

rjernst
Copy link
Contributor

@rjernst rjernst commented Jul 15, 2022

This commit adds try-with-resources for uses of Stream from Files
methods that walk directories.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8290359: Ensure that all directory streams are closed in jdk.link

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9520/head:pull/9520
$ git checkout pull/9520

Update a local copy of the PR:
$ git checkout pull/9520
$ git pull https://git.openjdk.org/jdk pull/9520/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9520

View PR using the GUI difftool:
$ git pr show -t 9520

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9520.diff

This commit adds try-with-resources for uses of Stream<Path> from Files
methods that walk directories.
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 15, 2022

👋 Welcome back rjernst! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 15, 2022
@openjdk
Copy link

openjdk bot commented Jul 15, 2022

@rjernst The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jul 15, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 15, 2022

Webrevs

name.endsWith(".RSA") ||
name.endsWith(".EC") ||
name.startsWith("META-INF/SIG-")
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivially, can we please keep the indentation consistent with the previous version. So, align all name.endsWith expressions under the 's' from startsWith.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in c628479

Copy link
Member

@ChrisHegarty ChrisHegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Jul 19, 2022

@rjernst This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290359: Ensure that all directory streams are closed in jdk.link

Reviewed-by: chegar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 57 new commits pushed to the master branch:

  • b1817a3: 8290468: Remove gc/gctests/mallocWithGC tests
  • eeb345a: 8290533: Remove G1ConcurrentMark::mark_in_bitmap(uint, HeapRegion*,oop)
  • 89458e3: 8288107: Auto-vectorization for integer min/max
  • 3d3e3df: 8290069: IGV: Highlight both graphs of difference in outline
  • 1c05507: 8289743: AArch64: Clean up patching logic
  • 011958d: 8290374: Shenandoah: Remove inaccurate comment on SBS::load_reference_barrier()
  • 984cd02: 8290707: runtime/cds/appcds/dynamicArchive/DynamicLambdaWithUseImplMethodHandle.java fails with "Can't find sun.hotspot.whitebox"
  • 4b4d352: 8264999: GeneralPath.lineTo() to itself produces jagged lines
  • 43c47b1: 8290534: Move MacroAssembler::verified_entry to C2_MacroAssembler on x86
  • 5425573: 8290496: riscv: Fix build warnings-as-errors with GCC 11
  • ... and 47 more: https://git.openjdk.org/jdk/compare/92067e200346c41c2f43763edc01c97c7da1a9e6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@ChrisHegarty) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 19, 2022
@rjernst
Copy link
Contributor Author

rjernst commented Jul 20, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 20, 2022
@openjdk
Copy link

openjdk bot commented Jul 20, 2022

@rjernst
Your change (at version 4e9eede) is now ready to be sponsored by a Committer.

@ChrisHegarty
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 21, 2022

Going to push as commit 3582fd9.
Since your change was applied there have been 74 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 21, 2022
@openjdk openjdk bot closed this Jul 21, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 21, 2022
@openjdk
Copy link

openjdk bot commented Jul 21, 2022

@ChrisHegarty @rjernst Pushed as commit 3582fd9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants