8285935: Spurious lint warning for static method accessed through instance qualifier

[vicente-romero-oracle]

Please review this simple fix which is adding a more precise, I hope, warning for the case when a static method or field is being accessed using an anonymous class instance.

TIA

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8285935: Spurious lint warning for static method accessed through instance qualifier

Reviewers

• Jan Lahoda (@lahodaj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9521/head:pull/9521
$ git checkout pull/9521

Update a local copy of the PR:
$ git checkout pull/9521
$ git pull https://git.openjdk.org/jdk pull/9521/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9521

View PR using the GUI difftool:
$ git pr show -t 9521

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9521.diff

[bridgekeeper]

👋 Welcome back vromero! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@vicente-romero-oracle The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (265a478e)
• 00: Full (1cff3326)

[lahodaj]

Seems OK to me.

[openjdk]

@vicente-romero-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8285935: Spurious lint warning for static method accessed through instance qualifier

Reviewed-by: jlahoda

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 224 new commits pushed to the master branch:

• d4a795d: 8283276: java/io/ObjectStreamClass/ObjectStreamClassCaching.java fails with various GCs
• a3040fc: 8291360: Create entry points to expose low-level class file information
• ce61eb6: 8290349: IP_DONTFRAGMENT doesn't set DF bit in IPv4 header
• 26e5c11: 4890041: Remove TAB and Shift TAB from Popup Menu in Motif Look & Feel
• 0bc804d: 8291762: Backout JDK-8291757 from jdk/jdk
• 3493973: Merge
• 43bb399: 8291757: Remove EA from JDK 19 version string starting with Initial RC promotion B35 on August 11, 2022
• 4772354: 8291825: java/time/nontestng/java/time/zone/CustomZoneNameTest.java fails if defaultLocale and defaultFormatLocale are different
• 1a6c83b: 8291798: VMRegImpl::print_on is broken after JDK-8289060
• b6b0317: 8290840: Refactor the "os" class
• ... and 214 more: https://git.openjdk.org/jdk/compare/f3abb82989e79da97bcc0a837883be41d14703a3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[vicente-romero-oracle]

@lahodaj thanks for the review

[vicente-romero-oracle]

/integrate

[openjdk]

Going to push as commit 3ba3171.
Since your change was applied there have been 227 commits pushed to the master branch:

• 92d2982: 8283232: x86: Improve vector broadcast operations
• 966ab21: 8291895: Remove PRAGMA_NONNULL_IGNORED from x86 and AArch64
• aa557b9: 8288327: Executable.hasRealParameterData should not be volatile
• d4a795d: 8283276: java/io/ObjectStreamClass/ObjectStreamClassCaching.java fails with various GCs
• a3040fc: 8291360: Create entry points to expose low-level class file information
• ce61eb6: 8290349: IP_DONTFRAGMENT doesn't set DF bit in IPv4 header
• 26e5c11: 4890041: Remove TAB and Shift TAB from Popup Menu in Motif Look & Feel
• 0bc804d: 8291762: Backout JDK-8291757 from jdk/jdk
• 3493973: Merge
• 43bb399: 8291757: Remove EA from JDK 19 version string starting with Initial RC promotion B35 on August 11, 2022
• ... and 217 more: https://git.openjdk.org/jdk/compare/f3abb82989e79da97bcc0a837883be41d14703a3...master

Your commit was automatically rebased without conflicts.

[openjdk]

@vicente-romero-oracle Pushed as commit 3ba3171.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.