Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8290374: Shenandoah: Remove inaccurate comment on SBS::load_reference_barrier() #9522

Closed

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Jul 15, 2022

Please review this trivial patch to remove inaccurate comment.

Even with separate mark-compact marking phase, we still need is_evacuation_in_progress() check to deal with the scenario that Full GC was upgraded from concurrent/degenerated GC.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8290374: Shenandoah: Remove inaccurate comment on SBS::load_reference_barrier()

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9522/head:pull/9522
$ git checkout pull/9522

Update a local copy of the PR:
$ git checkout pull/9522
$ git pull https://git.openjdk.org/jdk pull/9522/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9522

View PR using the GUI difftool:
$ git pr show -t 9522

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9522.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 15, 2022

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 15, 2022
@openjdk
Copy link

openjdk bot commented Jul 15, 2022

@zhengyu123 The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-gc hotspot-gc-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Jul 15, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 15, 2022

Webrevs

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, right. Looks good.

@openjdk
Copy link

openjdk bot commented Jul 20, 2022

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290374: Shenandoah: Remove inaccurate comment on SBS::load_reference_barrier()

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 65 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 20, 2022
@zhengyu123
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 20, 2022

Going to push as commit 011958d.
Since your change was applied there have been 66 commits pushed to the master branch:

  • 984cd02: 8290707: runtime/cds/appcds/dynamicArchive/DynamicLambdaWithUseImplMethodHandle.java fails with "Can't find sun.hotspot.whitebox"
  • 4b4d352: 8264999: GeneralPath.lineTo() to itself produces jagged lines
  • 43c47b1: 8290534: Move MacroAssembler::verified_entry to C2_MacroAssembler on x86
  • 5425573: 8290496: riscv: Fix build warnings-as-errors with GCC 11
  • a3e07d9: Merge
  • e062dff: 8290524: Typo in javadoc of MemorySegment/MemoryAddress
  • a6bab2a: 8288482: JFR: Cannot resolve method
  • 4dc421c: 8290417: CDS cannot archive lamda proxy with useImplMethodHandle
  • 2ea3f54: 8290495: Micro-optimize Method::can_be_statically_bound assertions
  • 9714791: 8190907: Windows 10 default Korean Font Malgun Gothic available not used by GUI elements even though available without Korean Language Pack
  • ... and 56 more: https://git.openjdk.org/jdk/compare/f3abb82989e79da97bcc0a837883be41d14703a3...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 20, 2022
@openjdk openjdk bot closed this Jul 20, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 20, 2022
@openjdk
Copy link

openjdk bot commented Jul 20, 2022

@zhengyu123 Pushed as commit 011958d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated shenandoah shenandoah-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants