Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8290460: Alpine: disable some panama tests that rely on std::thread #9539

Conversation

tstuefe
Copy link
Member

@tstuefe tstuefe commented Jul 18, 2022

Until JDK-8290059 is solved, I'd like to disable

  • java/foreign/TestUpcallAsync.java
  • java/foreign/enablenativeaccess/TestEnableNativeAccess.java

on muslc to take load from our CIs.

Tests: tested locally that the tests are excluded on Alpine, and remain active on other platforms.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8290460: Alpine: disable some panama tests that rely on std::thread

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9539/head:pull/9539
$ git checkout pull/9539

Update a local copy of the PR:
$ git checkout pull/9539
$ git pull https://git.openjdk.org/jdk pull/9539/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9539

View PR using the GUI difftool:
$ git pr show -t 9539

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9539.diff

@tstuefe tstuefe marked this pull request as ready for review July 18, 2022 14:22
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 18, 2022

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 18, 2022
@openjdk
Copy link

openjdk bot commented Jul 18, 2022

@tstuefe The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jul 18, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 18, 2022

Webrevs

Copy link
Member

@JornVernee JornVernee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk
Copy link

openjdk bot commented Jul 18, 2022

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290460: Alpine: disable some panama tests that rely on std::thread

Reviewed-by: jvernee, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

  • af86cd3: 8290463: Fix several comment typos in sun.security.ec
  • 6cd1c0c: Merge
  • 2677dd6: 8289954: C2: Assert failed in PhaseCFG::verify() after JDK-8183390
  • 4f3f74c: 8289127: Apache Lucene triggers: DEBUG MESSAGE: duplicated predicate failed which is impossible
  • 4a4d8ed: 8289801: [IR Framework] Add flags to whitelist which can be used to simulate a specific machine setup like UseAVX
  • 5a96a5d: 8289612: Change hotspot/jtreg tests to not use Thread.stop
  • b65f7ec: 4887998: Use Integer.rotateLeft() and rotateRight() in crypto implementations
  • 6c8d0e6: 8282526: Default icon is not painted properly
  • e72742e: 8286172: Create an automated test for JDK-4516019
  • b9de0a7: 8284524: Create an automated test for JDK-4422362
  • ... and 6 more: https://git.openjdk.org/jdk/compare/87340fd5408d89d9343541ff4fcabde83548a598...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 18, 2022
@tstuefe
Copy link
Member Author

tstuefe commented Jul 19, 2022

Thanks @JornVernee and @dholmes-ora !

/integrate

@openjdk
Copy link

openjdk bot commented Jul 19, 2022

Going to push as commit d7f0de2.
Since your change was applied there have been 18 commits pushed to the master branch:

  • dfbc691: 8289524: Add JFR JIT restart event
  • 4e6cd67: 8290000: Bump macOS GitHub actions to macOS 11
  • af86cd3: 8290463: Fix several comment typos in sun.security.ec
  • 6cd1c0c: Merge
  • 2677dd6: 8289954: C2: Assert failed in PhaseCFG::verify() after JDK-8183390
  • 4f3f74c: 8289127: Apache Lucene triggers: DEBUG MESSAGE: duplicated predicate failed which is impossible
  • 4a4d8ed: 8289801: [IR Framework] Add flags to whitelist which can be used to simulate a specific machine setup like UseAVX
  • 5a96a5d: 8289612: Change hotspot/jtreg tests to not use Thread.stop
  • b65f7ec: 4887998: Use Integer.rotateLeft() and rotateRight() in crypto implementations
  • 6c8d0e6: 8282526: Default icon is not painted properly
  • ... and 8 more: https://git.openjdk.org/jdk/compare/87340fd5408d89d9343541ff4fcabde83548a598...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 19, 2022
@openjdk openjdk bot closed this Jul 19, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 19, 2022
@openjdk
Copy link

openjdk bot commented Jul 19, 2022

@tstuefe Pushed as commit d7f0de2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants