8290495: Micro-optimize Method::can_be_statically_bound assertions

[shipilev]

See the rationale in the bug.

The test time improves:

# Before
real 1m27.397s
user 2m39.937s
sys 0m5.966s

# After
real 1m13.443s ; -16%
user 2m24.238s ; -10%
sys 0m5.885s

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8290495: Micro-optimize Method::can_be_statically_bound assertions

Reviewers

• David Holmes (@dholmes-ora - Reviewer)
• Thomas Stuefe (@tstuefe - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9548/head:pull/9548
$ git checkout pull/9548

Update a local copy of the PR:
$ git checkout pull/9548
$ git pull https://git.openjdk.org/jdk pull/9548/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9548

View PR using the GUI difftool:
$ git pr show -t 9548

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9548.diff

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (7a1b0d85)
• 00: Full (96d1e023)

[dholmes-ora]

As a general rule we don't care about the performance of non-product code. If you start down this path there is a huge amount of potential optimisation that might be done. Why is this one worthwhile?

Cheers.

[shipilev]

As a general rule we don't care about the performance of non-product code. If you start down this path there is a huge amount of potential optimisation that might be done. Why is this one worthwhile?

I run lots of testing, so I am interested in simple stuff that optimizes test times. The more generic solution, #9543, yields substantial reducing in test times, but Ioi wanted this one too.

[dholmes-ora]

I'll approve just to avoid spending more cycles on this but I'd hate to see this become common place. :)

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290495: Micro-optimize Method::can_be_statically_bound assertions

Reviewed-by: dholmes, stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

• e02627c: 8290397: LoadLibraryUnload.java failed with "Too few cleared WeakReferences"
• 2ff2208: 8289804: Remove redundant stream() call before forEach in jdk.jshell
• f5a7de8: 8290379: Parse error with parenthesized pattern and guard using an array
• 612d8c6: 8290456: remove os::print_statistics()
• d7f0de2: 8290460: Alpine: disable some panama tests that rely on std::thread
• dfbc691: 8289524: Add JFR JIT restart event
• 4e6cd67: 8290000: Bump macOS GitHub actions to macOS 11
• af86cd3: 8290463: Fix several comment typos in sun.security.ec
• 6cd1c0c: Merge
• 2677dd6: 8289954: C2: Assert failed in PhaseCFG::verify() after JDK-8183390
• ... and 13 more: https://git.openjdk.org/jdk/compare/87340fd5408d89d9343541ff4fcabde83548a598...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

I'll approve just to avoid spending more cycles on this but I'd hate to see this become common place. :)

True, I am on the fence about fiddling about every ResourceMark use. That's why I did the more generic thing in that other PR, so we can slap ResourceMark-s pretty much wherever without obsessing about these details. :)

[tstuefe]

Makes sense.

[shipilev]

Thanks all!

/integrate

[openjdk]

Going to push as commit 2ea3f54.
Since your change was applied there have been 43 commits pushed to the master branch:

• 9714791: 8190907: Windows 10 default Korean Font Malgun Gothic available not used by GUI elements even though available without Korean Language Pack
• 4358864: 8290511: compiler/vectorapi/TestMaskedMacroLogicVector.java fails IR verification
• 7b418f9: 8287916: Address the inconsistency between the constant array and pool size
• 41ef2b2: 8285407: Improve Xalan supports
• d991ec4: 8282676: Improve subject handling
• b7b917a: 8284370: Improve zlib usage
• a37465b: 8283190: Improve MIDI processing
• 632d2d2: 8281866: Enhance MethodHandle invocations
• 84b4e9b: 8281859: Improve class compilation
• e7f8003: 8272249: Better properties of loaded Properties
• ... and 33 more: https://git.openjdk.org/jdk/compare/87340fd5408d89d9343541ff4fcabde83548a598...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 2ea3f54.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.