8290529: C2: assert(BoolTest(btest).is_canonical()) failure #9553

rwestrel · 2022-07-19T12:28:10Z

For the test case:

In Parse::do_if(), tst0 is:

(Bool#lt (CmpU 0 Parm0))

transformed by gvn in tst:

(Bool#gt (CmpU Parm0 0))

That test is not canonical and is negated and retransformed which
results in:

(Bool#eq (CmpI Parm0 0))

The assert fires because that test is not canonical either.

The root cause I think is that the (CmpU .. 0) -> (CmpI .. 0) only
triggers if the condition of the CmpU is canonical (and results in a
non canonical test). Tweaking it so it applies even if the condition
is not leads to the following change in the steps above:

(Bool#ne (CmpI Parm0 0))

which is a canonical test.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8290529: C2: assert(BoolTest(btest).is_canonical()) failure

Reviewers

Vladimir Kozlov (@vnkozlov - Reviewer) ⚠️ Review applies to 8850b36c
Tobias Hartmann (@TobiHartmann - Reviewer) ⚠️ Review applies to 8850b36c

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9553/head:pull/9553
$ git checkout pull/9553

Update a local copy of the PR:
$ git checkout pull/9553
$ git pull https://git.openjdk.org/jdk pull/9553/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9553

View PR using the GUI difftool:
$ git pr show -t 9553

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9553.diff

bridgekeeper · 2022-07-19T12:28:26Z

👋 Welcome back roland! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2022-07-19T12:32:28Z

@rwestrel The following label will be automatically applied to this pull request:

hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2022-07-19T12:36:05Z

Webrevs

vnkozlov

Changes are good. If possible add IR framework test.

vnkozlov · 2022-07-20T19:31:51Z

src/hotspot/share/opto/subnode.cpp

@@ -1621,12 +1621,12 @@ Node *BoolNode::Ideal(PhaseGVN *phase, bool can_reshape) {
  // Change x u< 1 or x u<= 0 to x == 0


Update comment.

What about updating this comment.

Right. Sorry I forgot about that one. I updated the comment.

bridgekeeper · 2022-08-17T20:57:38Z

@rwestrel This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

rwestrel · 2022-08-18T15:31:45Z

Changes are good. If possible add IR framework test.

Thanks for looking a this. Are you asking that the test that I added to catch this specific problem be turned into and IR framework test or are you asking for a separate test to verify the transformation in general?

vnkozlov · 2022-08-29T18:47:33Z

Changes are good. If possible add IR framework test.

Thanks for looking a this. Are you asking that the test that I added to catch this specific problem be turned into and IR framework test or are you asking for a separate test to verify the transformation in general?

Separate IR test to verify the transformation in general.

rwestrel · 2022-08-30T13:58:25Z

Changes are good. If possible add IR framework test.

Thanks for looking a this. Are you asking that the test that I added to catch this specific problem be turned into and IR framework test or are you asking for a separate test to verify the transformation in general?

Separate IR test to verify the transformation in general.

I added one.

vnkozlov

Good.

openjdk · 2022-09-01T19:24:42Z

@rwestrel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290529: C2: assert(BoolTest(btest).is_canonical()) failure

Reviewed-by: kvn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 146 new commits pushed to the master branch:

bc5ffc8: 8293100: RISC-V: Need to save and restore callee-saved FloatRegisters in StubGenerator::generate_call_stub
98ce45f: 8292981: Unify and restructure integer printing format specifiers
3ac91b0: 8293003: Review running time of Warn5 regression test
e0168a0: 8288012: AArch64: unnecessary macro expansion in stubGenerator_aarch64
99c3ab0: 8293010: JDI ObjectReference/referringObjects/referringObjects001 fails: assert(env->is_enabled(JVMTI_EVENT_OBJECT_FREE)) failed: checking
0fb9469: 8290126: Add a check in JavadocTester for "javadoc should not crash"
0a4d0ce: 8293121: (fs) Refactor UnixFileSystem copying into generic Unix, Linux, and BSD implementations
032be16: 8292066: Convert TestInputArgument.sh and TestSystemLoadAvg.sh to java version
e393973: 8292990: Improve test coverage for XPath Axes: parent
fa68371: 8292584: assert(cb != __null) failed: must be with -XX:-Inline
... and 136 more: https://git.openjdk.org/jdk/compare/79597f1ea6844f374beeeba219719cd9d5fe7d03...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

TobiHartmann

Looks good to me.

So the root cause is JDK-8276162, correct?

rwestrel · 2022-09-02T06:57:25Z

So the root cause is JDK-8276162, correct?

It's the one that is causing it to show up now but JDK-8209544 is the one that introduced the bug.

rwestrel · 2022-09-02T06:57:49Z

@vnkozlov @TobiHartmann thanks for the reviews

rwestrel · 2022-09-02T08:30:31Z

For the record: Test CmpUWithZero.java requires the compareUnsigned intrinsic which in turn requires the CmpU3 only implemented on x86_64 so I made that test x86_64 only.

TobiHartmann · 2022-09-02T09:45:38Z

Thanks for the clarifications.

rwestrel · 2022-09-02T13:33:54Z

/integrate

openjdk · 2022-09-02T13:35:27Z

Going to push as commit 77e21c5.
Since your change was applied there have been 151 commits pushed to the master branch:

fcc0cf9: 8292375: Convert ProtectionDomainCacheTable to ResourceHashtable
6fc58b8: 8293207: Add assert to JVM_ReferenceRefersTo to clarify its API
ce06a3b: 8293023: Change CardTable::is_in_young signature
26cac08: 8293209: Parallel: Remove unused variables in PSParallelCompact::invoke
46523b8: 8293219: Microsoft toolchain selection picks 32-bit tools over 64-bit
bc5ffc8: 8293100: RISC-V: Need to save and restore callee-saved FloatRegisters in StubGenerator::generate_call_stub
98ce45f: 8292981: Unify and restructure integer printing format specifiers
3ac91b0: 8293003: Review running time of Warn5 regression test
e0168a0: 8288012: AArch64: unnecessary macro expansion in stubGenerator_aarch64
99c3ab0: 8293010: JDI ObjectReference/referringObjects/referringObjects001 fails: assert(env->is_enabled(JVMTI_EVENT_OBJECT_FREE)) failed: checking
... and 141 more: https://git.openjdk.org/jdk/compare/79597f1ea6844f374beeeba219719cd9d5fe7d03...master

Your commit was automatically rebased without conflicts.

openjdk · 2022-09-02T13:35:42Z

@rwestrel Pushed as commit 77e21c5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

rwestrel added 3 commits July 12, 2022 15:45

fix

e456e81

more

3229b31

test

e136c46

openjdk bot added the rfr Pull request is ready for review label Jul 19, 2022

openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jul 19, 2022

vnkozlov reviewed Jul 20, 2022

View reviewed changes

rwestrel added 2 commits August 30, 2022 15:09

Merge branch 'master' into JDK-8290529

0c97c72

IR test

f8656e4

openjdk bot removed the rfr Pull request is ready for review label Aug 30, 2022

whitespace

b28f798

openjdk bot added the rfr Pull request is ready for review label Aug 30, 2022

comment

8850b36

vnkozlov approved these changes Sep 1, 2022

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Sep 1, 2022

TobiHartmann approved these changes Sep 2, 2022

View reviewed changes

make CmpUWithZero test x64 only

a3c5557

openjdk bot added the integrated Pull request has been integrated label Sep 2, 2022

openjdk bot closed this Sep 2, 2022

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 2, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8290529: C2: assert(BoolTest(btest).is_canonical()) failure #9553

8290529: C2: assert(BoolTest(btest).is_canonical()) failure #9553

rwestrel commented Jul 19, 2022 •

edited by openjdk bot

Loading

bridgekeeper bot commented Jul 19, 2022

openjdk bot commented Jul 19, 2022

mlbridge bot commented Jul 19, 2022 •

edited

Loading

vnkozlov left a comment

vnkozlov Jul 20, 2022

vnkozlov Aug 30, 2022

rwestrel Aug 31, 2022

bridgekeeper bot commented Aug 17, 2022

rwestrel commented Aug 18, 2022

vnkozlov commented Aug 29, 2022

rwestrel commented Aug 30, 2022

vnkozlov left a comment

openjdk bot commented Sep 1, 2022 •

edited

Loading

TobiHartmann left a comment

rwestrel commented Sep 2, 2022

rwestrel commented Sep 2, 2022

rwestrel commented Sep 2, 2022

TobiHartmann commented Sep 2, 2022

rwestrel commented Sep 2, 2022

openjdk bot commented Sep 2, 2022

openjdk bot commented Sep 2, 2022

		@@ -1621,12 +1621,12 @@ Node BoolNode::Ideal(PhaseGVN phase, bool can_reshape) {
		// Change x u< 1 or x u<= 0 to x == 0

8290529: C2: assert(BoolTest(btest).is_canonical()) failure #9553

8290529: C2: assert(BoolTest(btest).is_canonical()) failure #9553

Conversation

rwestrel commented Jul 19, 2022 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Jul 19, 2022

openjdk bot commented Jul 19, 2022

mlbridge bot commented Jul 19, 2022 • edited Loading

Webrevs

vnkozlov left a comment

Choose a reason for hiding this comment

vnkozlov Jul 20, 2022

Choose a reason for hiding this comment

vnkozlov Aug 30, 2022

Choose a reason for hiding this comment

rwestrel Aug 31, 2022

Choose a reason for hiding this comment

bridgekeeper bot commented Aug 17, 2022

rwestrel commented Aug 18, 2022

vnkozlov commented Aug 29, 2022

rwestrel commented Aug 30, 2022

vnkozlov left a comment

Choose a reason for hiding this comment

openjdk bot commented Sep 1, 2022 • edited Loading

TobiHartmann left a comment

Choose a reason for hiding this comment

rwestrel commented Sep 2, 2022

rwestrel commented Sep 2, 2022

rwestrel commented Sep 2, 2022

TobiHartmann commented Sep 2, 2022

rwestrel commented Sep 2, 2022

openjdk bot commented Sep 2, 2022

openjdk bot commented Sep 2, 2022

rwestrel commented Jul 19, 2022 •

edited by openjdk bot

Loading

mlbridge bot commented Jul 19, 2022 •

edited

Loading

openjdk bot commented Sep 1, 2022 •

edited

Loading