Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8290468: Remove gc/gctests/mallocWithGC tests #9563

Closed
wants to merge 1 commit into from

Conversation

lmesnik
Copy link
Member

@lmesnik lmesnik commented Jul 19, 2022

The gc/gctests/mallocWithGC tests test interaction of GC with malloc/free.
They are duplicates of vmTestbase/gc/lock/malloc/ tests.
Not sure that even vmTestbase/gc/lock/malloc/ are needed. GC do nothing with malloc/free and it doesn't make sense to test their interaction.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9563/head:pull/9563
$ git checkout pull/9563

Update a local copy of the PR:
$ git checkout pull/9563
$ git pull https://git.openjdk.org/jdk pull/9563/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9563

View PR using the GUI difftool:
$ git pr show -t 9563

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9563.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 19, 2022

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 19, 2022
@openjdk
Copy link

openjdk bot commented Jul 19, 2022

@lmesnik The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Jul 19, 2022
@lmesnik
Copy link
Member Author

lmesnik commented Jul 19, 2022

/label remove hotspot

@lmesnik
Copy link
Member Author

lmesnik commented Jul 19, 2022

/cc hotspot-gc

@mlbridge
Copy link

mlbridge bot commented Jul 19, 2022

Webrevs

@openjdk openjdk bot removed the hotspot hotspot-dev@openjdk.org label Jul 19, 2022
@openjdk
Copy link

openjdk bot commented Jul 19, 2022

@lmesnik
The hotspot label was successfully removed.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Jul 19, 2022
@openjdk
Copy link

openjdk bot commented Jul 19, 2022

@lmesnik
The hotspot-gc label was successfully added.

Copy link

@kimbarrett kimbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Jul 20, 2022

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290468: Remove gc/gctests/mallocWithGC tests

Reviewed-by: kbarrett, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 20, 2022
Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@lmesnik
Copy link
Member Author

lmesnik commented Jul 20, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jul 20, 2022

Going to push as commit b1817a3.
Since your change was applied there have been 27 commits pushed to the master branch:

  • eeb345a: 8290533: Remove G1ConcurrentMark::mark_in_bitmap(uint, HeapRegion*,oop)
  • 89458e3: 8288107: Auto-vectorization for integer min/max
  • 3d3e3df: 8290069: IGV: Highlight both graphs of difference in outline
  • 1c05507: 8289743: AArch64: Clean up patching logic
  • 011958d: 8290374: Shenandoah: Remove inaccurate comment on SBS::load_reference_barrier()
  • 984cd02: 8290707: runtime/cds/appcds/dynamicArchive/DynamicLambdaWithUseImplMethodHandle.java fails with "Can't find sun.hotspot.whitebox"
  • 4b4d352: 8264999: GeneralPath.lineTo() to itself produces jagged lines
  • 43c47b1: 8290534: Move MacroAssembler::verified_entry to C2_MacroAssembler on x86
  • 5425573: 8290496: riscv: Fix build warnings-as-errors with GCC 11
  • a3e07d9: Merge
  • ... and 17 more: https://git.openjdk.org/jdk/compare/1af7c33df59cd043bdae3f681aeded2919dc27aa...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 20, 2022
@openjdk openjdk bot closed this Jul 20, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 20, 2022
@openjdk
Copy link

openjdk bot commented Jul 20, 2022

@lmesnik Pushed as commit b1817a3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@lmesnik lmesnik deleted the 8290468 branch June 5, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants