Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8290707: runtime/cds/appcds/dynamicArchive/DynamicLambdaWithUseImplMethodHandle.java fails with "Can't find sun.hotspot.whitebox" #9568

Closed
wants to merge 1 commit into from

Conversation

tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Jul 20, 2022

Hi all,

can I have reviews for this trivial fix of the sun.hotspot.whitebox dependency in a test added recently?

Testing: local test

Thanks,
Thomas


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8290707: runtime/cds/appcds/dynamicArchive/DynamicLambdaWithUseImplMethodHandle.java fails with "Can't find sun.hotspot.whitebox"

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9568/head:pull/9568
$ git checkout pull/9568

Update a local copy of the PR:
$ git checkout pull/9568
$ git pull https://git.openjdk.org/jdk pull/9568/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9568

View PR using the GUI difftool:
$ git pr show -t 9568

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9568.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 20, 2022

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8290707 8290707: runtime/cds/appcds/dynamicArchive/DynamicLambdaWithUseImplMethodHandle.java fails with "Can't find sun.hotspot.whitebox" Jul 20, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 20, 2022
@openjdk
Copy link

openjdk bot commented Jul 20, 2022

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Jul 20, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 20, 2022

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good and trivial. Thanks for fixing.

@openjdk
Copy link

openjdk bot commented Jul 20, 2022

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290707: runtime/cds/appcds/dynamicArchive/DynamicLambdaWithUseImplMethodHandle.java fails with "Can't find sun.hotspot.whitebox"

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 4b4d352: 8264999: GeneralPath.lineTo() to itself produces jagged lines
  • 43c47b1: 8290534: Move MacroAssembler::verified_entry to C2_MacroAssembler on x86

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 20, 2022
@tschatzl
Copy link
Contributor Author

Thanks @dholmes-ora for your review.

/integrate

@openjdk
Copy link

openjdk bot commented Jul 20, 2022

Going to push as commit 984cd02.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 4b4d352: 8264999: GeneralPath.lineTo() to itself produces jagged lines
  • 43c47b1: 8290534: Move MacroAssembler::verified_entry to C2_MacroAssembler on x86

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 20, 2022
@openjdk openjdk bot closed this Jul 20, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 20, 2022
@openjdk
Copy link

openjdk bot commented Jul 20, 2022

@tschatzl Pushed as commit 984cd02.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tschatzl tschatzl deleted the submit/8290707-sun-hotspot branch July 29, 2022 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
2 participants