8290687: serviceability/sa/TestClassDump.java could leave files owned by root on macOS

[plummercj]

Unless this test is run as root, it needs sudo privileges. If it gets them, the test runs fine, but leaves around files with root ownership so jtreg cannot delete them, and you see errors when "make clean" tries to delete them. It's best that we just don't run the test on OSX if sudo privileges.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8290687: serviceability/sa/TestClassDump.java could leave files owned by root on macOS

Reviewers

• Alex Menkov (@alexmenkov - Reviewer)
• Leonid Mesnik (@lmesnik - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9579/head:pull/9579
$ git checkout pull/9579

Update a local copy of the PR:
$ git checkout pull/9579
$ git pull https://git.openjdk.org/jdk pull/9579/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9579

View PR using the GUI difftool:
$ git pr show -t 9579

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9579.diff

[bridgekeeper]

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@plummercj The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (5f00afef)

[openjdk]

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290687: serviceability/sa/TestClassDump.java could leave files owned by root on macOS

Reviewed-by: amenkov, lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1392 new commits pushed to the master branch:

• e8975be: 8290746: ProblemList compiler/vectorization/TestAutoVecIntMinMax.java
• 9c19d89: Merge
• 17e65bb: 8290625: Test jdk/javadoc/tool/CheckManPageOptions.java after manpage update
• 618f3a8: 8278274: Update nroff pages in JDK 19 before RC
• f1001a0: 8287916: Address the inconsistency between the constant array and pool size
• 5d1c448: 8285407: Improve Xalan supports
• d0a2f13: 8282676: Improve subject handling
• 8333950: 8284370: Improve zlib usage
• 879ea78: 8283190: Improve MIDI processing
• 78c514d: 8281866: Enhance MethodHandle invocations
• ... and 1382 more: https://git.openjdk.org/jdk/compare/bf1c3ef02b22a615101530642d245fef899d33b7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[plummercj]

/integrate

[openjdk]

Going to push as commit 59d85ba.
Since your change was applied there have been 1408 commits pushed to the master branch:

• 66f59c2: 8290731: Clean up CDS handling of LambdaForm Species classes
• 0dda3c1: 8289275: Remove incorrect __declspec(dllimport) attributes from pointers in jdk.crypto.cryptoki
• 620c8a0: 8289643: File descriptor leak with ProcessBuilder.startPipeline
• 7ec0132: 8286844: com/sun/jdi/RedefineCrossEvent.java failed with 1 threads completed while VM suspended
• 80bd8c3: 8290504: Close streams returned by ModuleReader::list
• 15f4b30: 8290115: ArrayCopyObject JMH has wrong package
• 4c1cd66: 8288368: simplify code in ValueTaglet, remove redundant code
• 6346c33: 8290826: validate-source failures after JDK-8290016
• 604a115: 8290016: IGV: Fix graph panning when mouse dragged outside of window
• 59e495e: 8290704: x86: TemplateTable::_new should not call eden_allocate() without contiguous allocs enabled
• ... and 1398 more: https://git.openjdk.org/jdk/compare/bf1c3ef02b22a615101530642d245fef899d33b7...master

Your commit was automatically rebased without conflicts.

[openjdk]

@plummercj Pushed as commit 59d85ba.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.