8290806: Only add eager reclaim task to G1 post evacuate tasks if there were candidates

[tschatzl]

Hi all,

can I have reviews for this tiny optimization that does not enqueue the eager reclaim task if there were no eager reclaim candidates? This saves an iteration over all heap regions in applications that do not allocate humongous type arrays.

Testing: gha, gc/g1

Thanks,
Thomas

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8290806: Only add eager reclaim task to G1 post evacuate tasks if there were candidates

Reviewers

• Kim Barrett (@kimbarrett - Reviewer)
• Sangheon Kim (@sangheon - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9590/head:pull/9590
$ git checkout pull/9590

Update a local copy of the PR:
$ git checkout pull/9590
$ git pull https://git.openjdk.org/jdk pull/9590/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9590

View PR using the GUI difftool:
$ git pr show -t 9590

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9590.diff

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (6384c2f5)

[kimbarrett]

Looks good.

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290806: Only add eager reclaim task to G1 post evacuate tasks if there were candidates

Reviewed-by: kbarrett, sangheki

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 36 new commits pushed to the master branch:

• 330adc0: 8290969: DumpClassListCLDClosure incorrectly uses ResizeableResourceHashtable
• 28bbdc5: 8290972: ProblemList java/lang/ProcessBuilder/PipelineLeaksFD.java
• a6faf5d: 8290485: [vector] REVERSE_BYTES for byte type should not emit any instructions
• 0ca5cb1: 8290834: Improve potentially confusing documentation on collection of profiling information
• 7c3cfd1: 8290557: tools/jpackage/share/AddLauncherTest.java#id1 failed with "ERROR: Failed: Check icon file"
• 0ca74f5: 8289659: Refactor I/O stream copying to use InputStream.readAllBytes in X509CertPath
• 1e270ea: 8290780: AArch64: Crash in c2 nmethod running RunThese30M.java
• b17269a: 8290959: Consistently use "grey" instead of "gray" in GC code
• 350808a: 8290459: Remove unused GCCause enums
• d0c365a: 8170794: [macosx] Error when using setDesktopManager on a JDesktopPane on MacOS X with Look and Feel Aqua
• ... and 26 more: https://git.openjdk.org/jdk/compare/3582fd9e93d9733c6fdf1f3848e0a093d44f6865...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[sangheon]

Looks good.

[tschatzl]

Thanks @kimbarrett @sangheon for your reviews.

/integrate

[openjdk]

Going to push as commit da9cc5c.
Since your change was applied there have been 36 commits pushed to the master branch:

• 330adc0: 8290969: DumpClassListCLDClosure incorrectly uses ResizeableResourceHashtable
• 28bbdc5: 8290972: ProblemList java/lang/ProcessBuilder/PipelineLeaksFD.java
• a6faf5d: 8290485: [vector] REVERSE_BYTES for byte type should not emit any instructions
• 0ca5cb1: 8290834: Improve potentially confusing documentation on collection of profiling information
• 7c3cfd1: 8290557: tools/jpackage/share/AddLauncherTest.java#id1 failed with "ERROR: Failed: Check icon file"
• 0ca74f5: 8289659: Refactor I/O stream copying to use InputStream.readAllBytes in X509CertPath
• 1e270ea: 8290780: AArch64: Crash in c2 nmethod running RunThese30M.java
• b17269a: 8290959: Consistently use "grey" instead of "gray" in GC code
• 350808a: 8290459: Remove unused GCCause enums
• d0c365a: 8170794: [macosx] Error when using setDesktopManager on a JDesktopPane on MacOS X with Look and Feel Aqua
• ... and 26 more: https://git.openjdk.org/jdk/compare/3582fd9e93d9733c6fdf1f3848e0a093d44f6865...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tschatzl Pushed as commit da9cc5c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.