Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8290826: validate-source failures after JDK-8290016 #9594

Closed
wants to merge 1 commit into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Jul 21, 2022

A trivial fix for validate-source failures after JDK-8290016.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8290826: validate-source failures after JDK-8290016

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9594/head:pull/9594
$ git checkout pull/9594

Update a local copy of the PR:
$ git checkout pull/9594
$ git pull https://git.openjdk.org/jdk pull/9594/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9594

View PR using the GUI difftool:
$ git pr show -t 9594

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9594.diff

@dcubed-ojdk
Copy link
Member Author

/label add hotspot-runtime
/label add hotspot-compiler

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review July 21, 2022 15:23
@dcubed-ojdk
Copy link
Member Author

@azvegint - Thanks for the lightning fast review!

/integrate auto

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 21, 2022

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 21, 2022

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290826: validate-source failures after JDK-8290016

Reviewed-by: azvegint

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review hotspot-runtime hotspot-runtime-dev@openjdk.org labels Jul 21, 2022
@openjdk
Copy link

openjdk bot commented Jul 21, 2022

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jul 21, 2022
@openjdk
Copy link

openjdk bot commented Jul 21, 2022

@dcubed-ojdk
The hotspot-compiler label was successfully added.

@openjdk openjdk bot added the auto label Jul 21, 2022
@openjdk
Copy link

openjdk bot commented Jul 21, 2022

@dcubed-ojdk This pull request will be automatically integrated when it is ready

@mlbridge
Copy link

mlbridge bot commented Jul 21, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 21, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jul 21, 2022

Going to push as commit 6346c33.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 21, 2022
@openjdk openjdk bot closed this Jul 21, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 21, 2022
@openjdk
Copy link

openjdk bot commented Jul 21, 2022

@openjdk[bot] Pushed as commit 6346c33.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8290826 branch July 21, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto hotspot-compiler hotspot-compiler-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
2 participants