-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8290669: Fix wording in sun.security.ec #9606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @longxu0509, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user longxu0509" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
|
@longxu0509 The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
/signed |
|
You are already a known contributor! |
|
@longxu0509 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 38 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@seanjmullan) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
I think "noreg-trivial" is a more appropriate label for this bug than "noreg-cleanup". "noreg-cleanup", as defined in the OpenJDK Developer's Guide is: "Change is a cleanup or refactoring of existing code that is covered by existing tests." This fixes typos and removes one commented-out line, so it isn't changing any real code. |
|
Just changed the label in this JBS. |
|
/integrate |
|
@longxu0509 |
|
/sponsor |
|
Going to push as commit 2ae8e31.
Your commit was automatically rebased without conflicts. |
|
@johnshajiang @longxu0509 Pushed as commit 2ae8e31. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
this patch fixes several wording in sun.security.ec
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9606/head:pull/9606$ git checkout pull/9606Update a local copy of the PR:
$ git checkout pull/9606$ git pull https://git.openjdk.org/jdk pull/9606/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 9606View PR using the GUI difftool:
$ git pr show -t 9606Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9606.diff