Skip to content

Conversation

@longxu0509
Copy link

@longxu0509 longxu0509 commented Jul 22, 2022

this patch fixes several wording in sun.security.ec


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9606/head:pull/9606
$ git checkout pull/9606

Update a local copy of the PR:
$ git checkout pull/9606
$ git pull https://git.openjdk.org/jdk pull/9606/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9606

View PR using the GUI difftool:
$ git pr show -t 9606

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9606.diff

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Jul 22, 2022
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 22, 2022

Hi @longxu0509, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user longxu0509" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Jul 22, 2022

@longxu0509 The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Jul 22, 2022
@longxu0509
Copy link
Author

/signed

@bridgekeeper bridgekeeper bot removed the oca Needs verification of OCA signatory status label Jul 24, 2022
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 24, 2022

You are already a known contributor!

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 24, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 24, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 26, 2022

@longxu0509 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290669: Fix wording in sun.security.ec

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 38 new commits pushed to the master branch:

  • 8939095: 8289996: Fix array range check hoisting for some scaled loop iv
  • da9cc5c: 8290806: Only add eager reclaim task to G1 post evacuate tasks if there were candidates
  • 330adc0: 8290969: DumpClassListCLDClosure incorrectly uses ResizeableResourceHashtable
  • 28bbdc5: 8290972: ProblemList java/lang/ProcessBuilder/PipelineLeaksFD.java
  • a6faf5d: 8290485: [vector] REVERSE_BYTES for byte type should not emit any instructions
  • 0ca5cb1: 8290834: Improve potentially confusing documentation on collection of profiling information
  • 7c3cfd1: 8290557: tools/jpackage/share/AddLauncherTest.java#id1 failed with "ERROR: Failed: Check icon file"
  • 0ca74f5: 8289659: Refactor I/O stream copying to use InputStream.readAllBytes in X509CertPath
  • 1e270ea: 8290780: AArch64: Crash in c2 nmethod running RunThese30M.java
  • b17269a: 8290959: Consistently use "grey" instead of "gray" in GC code
  • ... and 28 more: https://git.openjdk.org/jdk/compare/3582fd9e93d9733c6fdf1f3848e0a093d44f6865...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@seanjmullan) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 26, 2022
@seanjmullan
Copy link
Member

I think "noreg-trivial" is a more appropriate label for this bug than "noreg-cleanup". "noreg-cleanup", as defined in the OpenJDK Developer's Guide is:

"Change is a cleanup or refactoring of existing code that is covered by existing tests."

This fixes typos and removes one commented-out line, so it isn't changing any real code.

@johnshajiang
Copy link
Member

Just changed the label in this JBS.
Thanks!

@longxu0509
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 26, 2022
@openjdk
Copy link

openjdk bot commented Jul 26, 2022

@longxu0509
Your change (at version 36a4b0d) is now ready to be sponsored by a Committer.

@johnshajiang
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 26, 2022

Going to push as commit 2ae8e31.
Since your change was applied there have been 38 commits pushed to the master branch:

  • 8939095: 8289996: Fix array range check hoisting for some scaled loop iv
  • da9cc5c: 8290806: Only add eager reclaim task to G1 post evacuate tasks if there were candidates
  • 330adc0: 8290969: DumpClassListCLDClosure incorrectly uses ResizeableResourceHashtable
  • 28bbdc5: 8290972: ProblemList java/lang/ProcessBuilder/PipelineLeaksFD.java
  • a6faf5d: 8290485: [vector] REVERSE_BYTES for byte type should not emit any instructions
  • 0ca5cb1: 8290834: Improve potentially confusing documentation on collection of profiling information
  • 7c3cfd1: 8290557: tools/jpackage/share/AddLauncherTest.java#id1 failed with "ERROR: Failed: Check icon file"
  • 0ca74f5: 8289659: Refactor I/O stream copying to use InputStream.readAllBytes in X509CertPath
  • 1e270ea: 8290780: AArch64: Crash in c2 nmethod running RunThese30M.java
  • b17269a: 8290959: Consistently use "grey" instead of "gray" in GC code
  • ... and 28 more: https://git.openjdk.org/jdk/compare/3582fd9e93d9733c6fdf1f3848e0a093d44f6865...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 26, 2022
@openjdk openjdk bot closed this Jul 26, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 26, 2022
@openjdk
Copy link

openjdk bot commented Jul 26, 2022

@johnshajiang @longxu0509 Pushed as commit 2ae8e31.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

3 participants